Skip to content

Add the drupal eslint plugin#28

Open
RedLucas wants to merge 1 commit intophase2:masterfrom
RedLucas:patch-1
Open

Add the drupal eslint plugin#28
RedLucas wants to merge 1 commit intophase2:masterfrom
RedLucas:patch-1

Conversation

@RedLucas
Copy link

@RedLucas RedLucas commented Jun 6, 2017

I personally don't think this takes anything away, but it'd be nice to have this in already for Drupal users.

I personally don't think this takes anything away, but it'd be nice to have this in already for Drupal users.
@illepic
Copy link
Contributor

illepic commented Aug 4, 2017

Revisiting this now that the Drupal 8.4 js coding standards are basically AirBnB: https://www.drupal.org/docs/develop/standards/javascript/eslint-settings

Note the core/package.json now including:

...
    "eslint": "3.19.0",
    "eslint-config-airbnb": "14.1.0",
    "eslint-plugin-import": "2.2.0",
    "eslint-plugin-jsx-a11y": "4.0.0",
    "eslint-plugin-react": "6.10.3",
...

Look for this config making it into p2-theme-core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants