enhancement/issue 13 Persistence for Docking Component Layout by philliplbryant · Pull Request #3 · philliplbryant/BentoFX

philliplbryant · 2026-04-27T17:26:08Z

This is a pre-pull request before submitting the "official" one to COL-E.

* Update StageBuilding `applyMousePosition` and `applySourceAsOwner` values. * Fix merge conflicts.

* Fix grammar.

* Remove Jacoco plugin.

* Enable and test publishing.

* Cleanup and matching master.

* Adjust dependency configurations.

* update comment.

* Add included Gradle build files.

* Remove TODO.

* Specify JDK and Gradle versions in version catalog. * Regenerate the Gradle wrapper scripts.

* Update `README.md` JDK and JavaFX versions.

# Conflicts: # build-logic/src/main/groovy/bento.project.project-convention.gradle # build.gradle # gradle.properties # gradle/libs.versions.toml # platform/build.gradle

…cement/issue-13

* Update `gradle.properties`.

* Remove JavaFX Gradle plugin from project convention. * Directly apply JavaFX Gradle plugin in `:core` and `:demos:basic`. * Revert JavaFX version to 21.0.9

* Upgrade Gradle from v9.6.1 to v9.7.0.

* Update SonarQube Cloud configuration to exclude core, demos/basic, and demos/persistence/resources.

* Update local SonarQube configuration to exclude core, demos/basic, and demos/persistence/resources.

* Delete local SonarQube configuration and use SonarQube Cloud.

This reverts commit d7a70eb.

* Restore local SonarQube configuration and delete configurations provided by SonarQube Cloud.

* Exclude `core`, `demos/basic`, and `demos/persistence/src/main/resources` from GitHub's Qodana action * Delete Qodana baseline * Delete the `update-qodana-baseline` action * Delete `/.github/analysis/qodana-baseline-sarif.json` file.

* Fix root branch to encode multiple children in order.

* Catch unchecked exceptions when decoding

* Check POM published by Gradle to validate it.

* Cleanup JSON.

* Cleanup DTOs.

* Make comments less verbose.

* Rename children to child dock containers.

* Minor cleanup.

The codec settled on Jackson, but codec.common still declared MOXy and jakarta.annotation as compileOnly dependencies and required jakarta.annotation in its module descriptor. No source in the module uses either, and no build puts MOXy on a path, so the declarations only described a mapper that was never wired up. Both are gone, along with the two catalog entries they were the last reference to, and the mapper's Javadoc no longer claims the DTOs are for JAXB.

…eview Every fixed and won't-fix finding now names its date and its commit, so the table says what is safe to build on without cross-referencing the log. The twelve minors are all that stay open.

* Minor cleanup.

* Prevent file storage from destroying previously saved layout on failure.

* Fix minor findings from Claude review.

* Update JSpecify version.

* Dependabot updates.

* Cleanup storage items from Claude review.

* Modify so whoever creates the `EntityManagerFactory` is also responsible for closing it.

* Update to use Qodana Ultimate.

* Throw an `IOException` when attempting to open a layout that hasn't been saved.

* Clean up findings from Claude review of file storage.

Phil Bryant added 14 commits April 21, 2026 17:06

BENTO-31:

e656fe2

* Update StageBuilding `applyMousePosition` and `applySourceAsOwner` values. * Fix merge conflicts.

BENTO-31:

93267fa

* Fix grammar.

BENTO-31:

c8c4334

* Fix grammar.

BENTO-31:

717745a

* Fix grammar.

BENTO-31:

f1902a0

* Remove Jacoco plugin.

BENTO-31:

3e2a4f6

* Enable and test publishing.

BENTO-31:

a8448b8

* Cleanup and matching master.

BENTO-31:

672237b

* Adjust dependency configurations.

BENTO-31:

415a3d8

* update comment.

BENTO-35:

dc3ee53

* Add included Gradle build files.

BENTO-13:

2094e33

* Remove TODO.

BENTO-35: Initial commit.

3e136db

BENTO-35: Cleanup (currently) unused dependencies.

06bb697

BENTO-35: Add TODO to remove DAGP.

f8fa963

philliplbryant requested review from ianbrandt and richmeyer7 April 27, 2026 17:26

philliplbryant self-assigned this Apr 27, 2026

Phil Bryant added 4 commits April 27, 2026 12:40

BENTO-35: Cleanup (currently) unused dependencies.

c2f8243

BENTO-35:

71cbb73

* Specify JDK and Gradle versions in version catalog. * Regenerate the Gradle wrapper scripts.

BENTO-35:

8038938

* Specify JDK and Gradle versions in version catalog. * Regenerate the Gradle wrapper scripts.

BENTO-35:

d323f51

* Update `README.md` JDK and JavaFX versions.

philliplbryant marked this pull request as draft April 27, 2026 18:47

philliplbryant removed request for ianbrandt and richmeyer7 April 27, 2026 18:48

philliplbryant changed the title ~~Enhancement/issue 13~~ enhancement/issue 13 Persistence for Docking Component Layout Apr 27, 2026

Phil Bryant added 5 commits April 27, 2026 17:50

Merge branch 'enhancement/issue-35' into enhancement/issue-13

b1c92b8

# Conflicts: # build-logic/src/main/groovy/bento.project.project-convention.gradle # build.gradle # gradle.properties # gradle/libs.versions.toml # platform/build.gradle

Merge remote-tracking branch 'origin/enhancement/issue-13' into enhan…

76401e3

…cement/issue-13

BENTO-35:

4c8b1f8

* Update `gradle.properties`.

Merge branch 'enhancement/issue-35' into enhancement/issue-13

010bf5f

BENTO-35:

cb5b691

* Remove JavaFX Gradle plugin from project convention. * Directly apply JavaFX Gradle plugin in `:core` and `:demos:basic`. * Revert JavaFX version to 21.0.9

Phil Bryant added 30 commits August 13, 2026 11:14

BENTO-13:

3b3b3eb

* Upgrade Gradle from v9.6.1 to v9.7.0.

BENTO-13:

8fb0e58

* Update SonarQube Cloud configuration to exclude core, demos/basic, and demos/persistence/resources.

BENTO-13:

bcb26ca

* Update local SonarQube configuration to exclude core, demos/basic, and demos/persistence/resources.

BENTO-13:

d7a70eb

* Delete local SonarQube configuration and use SonarQube Cloud.

Revert "BENTO-13:"

ee889e0

This reverts commit d7a70eb.

BENTO-13:

0aed0aa

* Restore local SonarQube configuration and delete configurations provided by SonarQube Cloud.

BENTO-13:

ffb48eb

* Exclude `core`, `demos/basic`, and `demos/persistence/src/main/resources` from GitHub's Qodana action * Delete Qodana baseline * Delete the `update-qodana-baseline` action * Delete `/.github/analysis/qodana-baseline-sarif.json` file.

BENTO-13:

afbd3c4

* Fix root branch to encode multiple children in order.

BENTO-13:

fad5954

* Catch unchecked exceptions when decoding

BENTO-13:

2de813f

* Check POM published by Gradle to validate it.

BENTO-13:

11a3859

* Cleanup JSON.

BENTO-13:

1a9a2d2

* Cleanup DTOs.

BENTO-13:

eb4a579

* Make comments less verbose.

BENTO-13:

4f9d017

* Rename children to child dock containers.

BENTO-13:

76bf756

* Minor cleanup.

BENTO-13: * Record the commit that closed each finding in the codec r…

411dca0

…eview Every fixed and won't-fix finding now names its date and its commit, so the table says what is safe to build on without cross-referencing the log. The twelve minors are all that stay open.

BENTO-13:

b6b5f9a

* Minor cleanup.

BENTO-13:

03fbca0

* Minor cleanup.

BENTO-13:

736d93f

* Minor cleanup.

BENTO-13:

4490597

* Prevent file storage from destroying previously saved layout on failure.

BENTO-13:

f545f9a

* Fix minor findings from Claude review.

BENTO-13:

26564c4

* Update JSpecify version.

BENTO-13:

263e4da

* Dependabot updates.

BENTO-13:

e89007b

* Cleanup storage items from Claude review.

BENTO-13:

86119a4

* Modify so whoever creates the `EntityManagerFactory` is also responsible for closing it.

BENTO-13:

151093d

* Update to use Qodana Ultimate.

BENTO-13:

5b48b05

* Throw an `IOException` when attempting to open a layout that hasn't been saved.

BENTO-13:

f3359f2

* Clean up findings from Claude review of file storage.

BENTO-13:

f67689c

* Clean up findings from Claude review of file storage.

Navigation Menu

enhancement/issue 13 Persistence for Docking Component Layout - #3

enhancement/issue 13 Persistence for Docking Component Layout#3
philliplbryant wants to merge 267 commits into
masterfrom
enhancement/issue-13

philliplbryant commented Apr 27, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

philliplbryant commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

philliplbryant commented Apr 27, 2026 •

edited

Loading