Prevents type errors when initializing a Metadata instance.#135
Open
tyrsson wants to merge 3 commits intophp-db:0.6.xfrom
Open
Prevents type errors when initializing a Metadata instance.#135tyrsson wants to merge 3 commits intophp-db:0.6.xfrom
tyrsson wants to merge 3 commits intophp-db:0.6.xfrom
Conversation
Needs tested against various driver packages. Signed-off-by: Joey Smith <jsmith@webinertia.net>
tyrsson
added
bug
Needs tested against various driver packages. Signed-off-by: Joey Smith <jsmith@webinertia.net>
…ithub.com/tyrsson/phpdb into patch-metadata-abstract-source-get-column
simon-mundy
requested changes
Feb 24, 2026
Collaborator
simon-mundy
left a comment
simon-mundy
left a comment
There was a problem hiding this comment.
If we can bump those new lines in under 120 chars then we're good to go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs tested against various driver packages. Signed-off-by: Joey Smith jsmith@webinertia.net
Description
Prevents the new strict typing in Column from choking on the returned values of the query since at times the database server will return int columns as strings.