Fixed bug where Result::count was prematurely returned#136
Merged
simon-mundy merged 2 commits intophp-db:0.6.xfrom Feb 25, 2026
Merged
Fixed bug where Result::count was prematurely returned#136simon-mundy merged 2 commits intophp-db:0.6.xfrom
simon-mundy merged 2 commits intophp-db:0.6.xfrom
Conversation
Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>
simon-mundy
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A bug in Result::count() meant that when it was initialized with a value of 0 it was then incorrectly returning 0 when being tested by 'is_int' and therefore reporting incorrect results. Fixed the definition and initialize() to ensure this is properly returned by querying the resource.