Fix bindParametersFromContainer() to prevent invalid parameter name characters#137
Merged
simon-mundy merged 1 commit intophp-db:0.6.xfrom Feb 25, 2026
Merged
Conversation
…PermittedBindParamName New unit tests for Base Parameter Container Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>
simon-mundy
changed the title
simon-mundy
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A test from phpdb-mysql in
PhpDbIntegrationTest\Mysql\Pdo\QueryTestcalledtestSelectWithNotPermittedBindParamNamewas marked 'incomplete' but in reality it belongs in the core package.The validation already exists in the vendor package at AbstractPdo::formatParameterName() (line 146: /[^a-zA-Z0-9_]/), but it's only called from the SQL builder path — never for raw queries.
The problem is that the PDO Statement::bindParametersFromContainer() at src/Adapter/Driver/Pdo/Statement.php:227 constructs the parameter name and passes it straight to PDO::bindParam() without validating it. PDO silently accepts invalid characters like $.
This fixes the issue right within the Statement at bindParametersFromContainer just before the params hit the PDO resource.