upgrade to integration tests 4 #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
force-pushed
the
integration-tests-4
branch
2 times, most recently
from
09ef415 to
87dfbac
Compare
dbu
force-pushed
the
integration-tests-4
branch
from
87dfbac to
15f22b9
Compare
dbu
force-pushed
the
integration-tests-4
branch
from
15f22b9 to
a177d58
Compare
dbu
commented
Jan 10, 2026
| private function collectOpenSslErrors(): string | ||
| { | ||
| $errors = []; | ||
| while (false !== ($error = openssl_error_string())) { |
Contributor
Author
There was a problem hiding this comment.
took me quite a while to figure out my tests locally failed because the ssl certificates that we generate for the tests have been outdated.
dbu
commented
Jan 10, 2026
| $metadatas = stream_get_meta_data($socket); | ||
|
|
||
| if (array_key_exists('timed_out', $metadatas) && true === $metadatas['timed_out']) { | ||
| if ($metadatas['timed_out']) { |
Contributor
Author
There was a problem hiding this comment.
this key is always present, and phpstan complains about the unnecessary check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.