Skip to content

Fix bug in materialized CTE #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veewee merged 1 commit into from
Apr 13, 2026
Merged

Fix bug in materialized CTE #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Query/CompositeQuery.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,8 @@ public function toSQL(): string
'%s AS %s(%s)',
$alias,
match (true) {
$query[1]?->materialized ?? null === true => 'MATERIALIZED ',
$query[1]?->materialized ?? null === false => 'NOT MATERIALIZED ',
($query[1]?->materialized ?? null) === true => 'MATERIALIZED ',
($query[1]?->materialized ?? null) === false => 'NOT MATERIALIZED ',
default => '',
},
Comment on lines 267 to 271

@jdreesen jdreesen Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not like this?

match ($query[1]?->materialized ?? null) {
    true => 'MATERIALIZED ',
    false => 'NOT MATERIALIZED ',
    default => '',
},

https://3v4l.org/uqFNN

@veewee veewee Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to send it as an improvement :)

I was just bumping against this issue and fixed it quickly without looking to the surroundings too much :)

@jdreesen jdreesen Apr 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#27

$query[0]->getSQL()
Expand Down
Loading