Skip to content

GenConfigCommand - print wsdl loading exceptions when output is verbose #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veewee merged 4 commits into from
May 28, 2026
Merged

GenConfigCommand - print wsdl loading exceptions when output is verbose #610

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee74445
GenConfigCommand| print wsdl loading exceptions when output is verbose
YasserB94 May 27, 2026
4287b26
Fix - revert formatting changes
YasserB94 May 28, 2026
2532534
GenerateConfigCommand - use io->error for verbose exceptions
YasserB94 May 28, 2026
1153321
GenerateConfigCommand - always print wsdl loading errors
YasserB94 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/Phpro/SoapClient/Console/Command/GenerateConfigCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,20 @@ protected function execute(InputInterface $input, OutputInterface $output): int
$context->setWsdl($wsdlUri);

$io->warning('Attempting to load WSDL... (this might take a while)');
$wsdl = $this->loadWsdl($wsdlUri);

if (!$wsdl) {
try {
$wsdl = $this->loadWsdl($wsdlUri);
} catch (\Throwable $e) {
$io->warning('Could not load the provided WSDL with default engine options.');
$io->error([$e::class,$e->getMessage()]);
if ($output->isVeryVerbose()) {
$io->text(explode("\n", $e->getTraceAsString()));
}
$io->info('Continuing generating configuration...');
$wsdl = null;
}


$context->setDetectedXmlNamespaces($wsdl?->namespaces->namespaceToNameMap ?? []);
$context->setGenerateDocblocks($io->confirm('Should methods be generated with docblocks?', true));
$name = $io->ask(
Expand Down Expand Up @@ -107,15 +114,11 @@ protected function execute(InputInterface $input, OutputInterface $output): int
return self::SUCCESS;
}

private function loadWsdl(string $wsdl): ?Wsdl1
private function loadWsdl(string $wsdl): Wsdl1
{
try {
$options = EngineOptions::defaults($wsdl);
$loader = $options->getWsdlLoader();

return (new Wsdl1Reader($loader))($wsdl);
} catch (\Throwable) {
return null;
}
}
}
Loading