Skip to content

Add createBuilder() and createNamedBuilder() to the FormFactoryInterface stub #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staabm merged 1 commit into from
Oct 25, 2026
Merged

Add createBuilder() and createNamedBuilder() to the FormFactoryInterface stub #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions stubs/Symfony/Component/Form/FormFactoryInterface.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,32 @@ interface FormFactoryInterface
* @throws \Symfony\Component\OptionsResolver\Exception\InvalidOptionsException
*/
public function createNamed(string $name, string $type = FormType::class, $data = null, array $options = []): FormInterface;

/**
* @template TFormType of FormTypeInterface<TData>
* @template TData
*
* @param class-string<TFormType> $type
* @param TData $data
* @param array<string, mixed> $options
*
* @phpstan-return ($data is null ? FormBuilderInterface<null|TData> : FormBuilderInterface<TData>)
*
* @throws \Symfony\Component\OptionsResolver\Exception\InvalidOptionsException
*/
public function createBuilder(string $type = FormType::class, $data = null, array $options = []): FormBuilderInterface;

/**
* @template TFormType of FormTypeInterface<TData>
* @template TData
*
* @param class-string<TFormType> $type
* @param TData $data
* @param array<string, mixed> $options
*
* @phpstan-return ($data is null ? FormBuilderInterface<null|TData> : FormBuilderInterface<TData>)
*
* @throws \Symfony\Component\OptionsResolver\Exception\InvalidOptionsException
*/
public function createNamedBuilder(string $name, string $type = FormType::class, $data = null, array $options = []): FormBuilderInterface;
}
27 changes: 27 additions & 0 deletions tests/Type/Symfony/data/form_data_type.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,33 @@ public function doSomethingNullable(): void
assertType('GenericFormDataType\DataClass|null', $form->getData());
}

public function doSomethingWithBuilder(): void
{
$builder = $this->formFactory->createBuilder(DataClassType::class, new DataClass());
assertType('Symfony\Component\Form\FormBuilderInterface<GenericFormDataType\DataClass>', $builder);
assertType('GenericFormDataType\DataClass', $builder->getData());
assertType('GenericFormDataType\DataClass|null', $builder->getForm()->getData());
}

public function doSomethingNullableWithBuilder(): void
{
$builder = $this->formFactory->createBuilder(DataClassType::class);
assertType('GenericFormDataType\DataClass|null', $builder->getData());
}

public function doSomethingWithNamedBuilder(): void
{
$builder = $this->formFactory->createNamedBuilder('data_class', DataClassType::class, new DataClass());
assertType('Symfony\Component\Form\FormBuilderInterface<GenericFormDataType\DataClass>', $builder);
assertType('GenericFormDataType\DataClass', $builder->getData());
}

public function doSomethingNullableWithNamedBuilder(): void
{
$builder = $this->formFactory->createNamedBuilder('data_class', DataClassType::class);
assertType('GenericFormDataType\DataClass|null', $builder->getData());
}

}

class FormController extends AbstractController
Expand Down
Loading