feat: restructure PCL as standalone workspace#78
Merged
Conversation
mateo-mro
force-pushed
the
mateo/feat-pcl-extraction
branch
5 times, most recently
from
83ff548 to
70f947a
Compare
fredo
reviewed
Apr 14, 2026
fredo
reviewed
Apr 14, 2026
Contributor
|
Nit: PR is also removing the readme |
mateo-mro
force-pushed
the
mateo/feat-pcl-extraction
branch
from
70f947a to
113af62
Compare
mateo-mro
force-pushed
the
mateo/feat-pcl-extraction
branch
from
113af62 to
bfb0e32
Compare
Contributor
Author
|
Added README back. |
lean-apple
reviewed
Apr 14, 2026
lean-apple
reviewed
Apr 14, 2026
lean-apple
left a comment
lean-apple
left a comment
There was a problem hiding this comment.
some suggestions, can be done in follow-up prs but we should reuse our ci workflows
mateo-mro
force-pushed
the
mateo/feat-pcl-extraction
branch
from
bfb0e32 to
9cbc0bb
Compare
fredo
previously approved these changes
Apr 14, 2026
mateo-mro
force-pushed
the
mateo/feat-pcl-extraction
branch
from
9cbc0bb to
4e89059
Compare
Move PCL into its own workspace with 5 crates: - pcl-cli: CLI binary entry point - pcl-core: CLI logic (auth, config, download, apply) - pcl-common: shared types - pcl-phoundry: Foundry/Solidity build integration - dapp-api-client: generated platform API client Feature structure: - Default build: config, auth, download, build, apply (5 commands) - `credible` feature: adds test + verify commands (requires assertion-executor and assertion-verification from credible-sdk) Dependency pinning: - phoundry deps pinned to rev 9289aae5 with default-features = false - alloy ecosystem patched to v1.1.3 to match phoundry's versions - credible-sdk deps (assertion-executor, assertion-verification) pinned to rev 3387cf96, optional behind `credible` feature
mateo-mro
force-pushed
the
mateo/feat-pcl-extraction
branch
from
4e89059 to
27e2fe0
Compare
lean-apple
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restructures PCL into a self-contained Cargo workspace with its own release and dependency management.
pcl-cli,pcl-core,pcl-common,pcl-phoundry,dapp-api-clientcrediblefeature flag gates assertion execution functionality (test,verifycommands)config,auth,download,build,apply--features fullenables all 7 subcommandsDependency pinning
9289aae5withdefault-features = false[patch.crates-io]to match phoundrycrediblefeature