[Studio UI] General styling review — improvements and fixes - #3860
Closed
idaiv wants to merge 11 commits into
Closed
[Studio UI] General styling review — improvements and fixes#3860idaiv wants to merge 11 commits into
idaiv wants to merge 11 commits into
Conversation
…earches, user management Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… via position absolute Use `position: relative` on .ant-tabs-tabpane and `position: absolute; inset: 0` on its direct child to give ContentLayout a pixel-definite height, allowing the CSS Grid `1fr` row to allocate space correctly so NoContent is vertically centered and the toolbar stays pinned to the bottom. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… Search modal title - Wrap ContentLayout in position:absolute inset:0 div so it gets a definite height from the tabpane's bounding box, making the CSS Grid 1fr row work and NoContent vertically centered with toolbar pinned to bottom - Add 'Quick Search' title to the search modal Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…to 4px The blanket position:absolute on tabpane > * broke General/Asset/Document/Object tabs by giving ContentLayout a fixed height while their pagination toolbar was inside the scrollable content area. The saved-searches wrapper already has inline position:absolute so the fix there is independent. Also reduce modal header-to-body gap from marginSM (~12px) to 4px as requested. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…Padding tabs - Extend tabs--no-padding to also zero the inter-tab margin-left so tabs sit flush with only their 4px item padding providing separation - Apply noPadding to the search modal Tabs so the quick search tab bar has no outer nav-list padding and no gap between tabs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… height Wrap SplitLayout in a flex:1 div and move the Toolbar below it as a flex:0 sibling so pagination is always visible regardless of available height. Also change inner Content height from fixed 400px to 100% so the results list fills its allocated flex space. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…grid config cleanup - Add responsive collapse for Simple/Advanced buttons in grid config toolbar: two buttons by default, collapsing to a split button when space is tight - Add missing translations for type dropdown items (newsletter, object, variant) across all 7 locales to fix raw lowercase keys showing in the search modal - Remove close icon from Cancel button in Save Configuration template view Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The react-hooks/exhaustive-deps rule is not configured in this repo's ESLint setup, so referencing it in an inline disable comment fails the frontend build lint step. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
10 tasks
2 tasks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been split into focused PRs
This PR contained too many topics for effective review. It has been split into the following individual PRs:
Please review the individual PRs above. This PR can be closed.