VSB single namespace support#337
Closed
vkrishna1084 wants to merge 13 commits into
Closed
Conversation
dtrailin
reviewed
Oct 2, 2025
| f"PineconeDB: Deleting existing index '{self.index_name}' before " | ||
| f"population (--overwrite=True)" | ||
| ) | ||
| self.index.delete(delete_all=True) |
Contributor
There was a problem hiding this comment.
You should keep the ability to overwrite an index as well.
Contributor
Author
There was a problem hiding this comment.
I thought of that but it was confusing on how would we overwrite an index, if we are operating at namespace level? Will there be a scenario where we want to overwrite an entire index?
Contributor
There was a problem hiding this comment.
Provided that it has the same functionality for reusing the same an name it should be fine. The main difference is that before you would get back a new index ID which made it easier to look at traces.
dtrailin
approved these changes
Oct 2, 2025
…d removing Pod from integration tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VSB previously lacked support for working with namespaces. Data could only be loaded into or queried from the default namespace at the index level.
Solution
This update extends VSB to support namespaces by adding functionality to:
Type of Change
Test Plan