Skip to content

VSB single namespace support#337

Closed
vkrishna1084 wants to merge 13 commits into
mainfrom
vsb_single_namespace
Closed

VSB single namespace support#337
vkrishna1084 wants to merge 13 commits into
mainfrom
vsb_single_namespace

Conversation

@vkrishna1084

Copy link
Copy Markdown
Contributor

Problem

VSB previously lacked support for working with namespaces. Data could only be loaded into or queried from the default namespace at the index level.

Solution

This update extends VSB to support namespaces by adding functionality to:

  1. Check if the namespace exist.
  2. Overwrite a namespace if it already exists (when specified).
  3. Load data into a specified namespace within an index.
  4. Query data from a specified namespace within an index.
  5. Fetch data from a specified namespace within an index.
  6. Delete records from a specified namespace within an index.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

  1. Run the benchmarking with a specified namespace (see Pinecone ReadMe for instructions).
  2. Test with an existing namespace (without --overwrite) → the process should fail.
  3. Test with an existing namespace and --overwrite → the existing namespace should be deleted and recreated, with new data loaded.
  4. Test with an existing namespace and --skip_populate → the populate phase should be skipped, and the query phase should run directly.

f"PineconeDB: Deleting existing index '{self.index_name}' before "
f"population (--overwrite=True)"
)
self.index.delete(delete_all=True)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should keep the ability to overwrite an index as well.

@vkrishna1084 vkrishna1084 Oct 2, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought of that but it was confusing on how would we overwrite an index, if we are operating at namespace level? Will there be a scenario where we want to overwrite an entire index?

@dtrailin dtrailin Oct 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided that it has the same functionality for reusing the same an name it should be fine. The main difference is that before you would get back a new index ID which made it easier to look at traces.

@vkrishna1084 vkrishna1084 deleted the vsb_single_namespace branch October 6, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants