Skip to content

Conversation

@jhamon
Copy link
Collaborator

@jhamon jhamon commented Jan 29, 2026

Summary

  • Pin Pinecone Python SDK to ~=8.0 in docs/pinecone-import.ipynb
  • Apply code formatting with ruff

This keeps the notebook up to date with the latest SDK version.

Test plan

  • Verify notebook JSON is valid
  • Confirm notebook executes successfully in Colab

Related


Note

Low Risk
Low risk documentation/example-only changes; main risk is that notebook runtime behavior changes if the new pinned SDK/API usage diverges from what the notebook expects.

Overview
Updates docs/pinecone-import.ipynb to pin the Pinecone Python SDK to pinecone~=8.0 and aligns imports/usage accordingly.

Applies formatting and minor cleanup throughout the notebook (import ordering, consistent quoting/line wrapping), and adds missing S3 upload dependencies (BytesIO, botocore Config/UNSIGNED, ClientError) while simplifying the S3 upload helper logic.

Written by Cursor Bugbot for commit f247fa8. This will update automatically on new commits. Configure here.

Pin Pinecone Python SDK to ~=8.0 and apply code formatting.

Ref: SDK-128
@jhamon jhamon added the documentation Improvements or additions to documentation label Jan 29, 2026
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jhamon
Copy link
Collaborator Author

jhamon commented Jan 29, 2026

CI Status Note

The CI failures are pre-existing issues in the notebook, not related to the SDK version update in this PR.

Lint failures (F821 undefined names): The notebook has Config, UNSIGNED, BytesIO, and ClientError used without explicit imports in the same cell. These are likely imported in earlier cells or work in the notebook execution context but fail static analysis.

This PR's changes:

  • Pinned pinecone to ~=8.0 (previously unpinned)
  • Applied code formatting with ruff

The pre-existing lint issues should be addressed in a separate PR to properly add the missing imports.

- Add BytesIO (io), Config/UNSIGNED (botocore.config), ClientError (botocore.exceptions)
- Remove unused total_chunks assignment in upload_to_s3
- Resolves F821/F841 lint failures in CI
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

"\n",
"import boto3\n",
"import pandas as pd\n",
"from botocore.config import UNSIGNED, Config\n",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect import path for botocore UNSIGNED constant

High Severity

The UNSIGNED constant is incorrectly imported from botocore.config. The UNSIGNED constant is defined at the top level of the botocore module, not in botocore.config. The correct import is from botocore import UNSIGNED while Config remains imported from botocore.config. This will cause an ImportError when the notebook cell executes, preventing the notebook from running successfully.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants