Skip to content

Conversation

@jhamon
Copy link
Collaborator

@jhamon jhamon commented Jan 29, 2026

Summary

Modernize learn/search/question-answering/table-qa.ipynb to use Pinecone SDK v8 and align with style guidelines.

Changes

  • Package: pinecone-clientpinecone
  • Client: Initialize with Pinecone(api_key=...) and ServerlessSpec(cloud="aws", region="us-east-1")
  • Index: Use pc.has_index(name=...), pc.create_index(..., spec=ServerlessSpec(...)), pc.Index(name=...)
  • API key: Environment variable PINECONE_API_KEY or getpass fallback
  • Query response: Use result.matches[0].id for v8 response shape
  • Prose: Timeless intro; "initialize a client" language
  • Cleanup: Added section to delete the index when done

Linear

  • SDK-141 Modernize SDK: table-qa.ipynb

Checklist

  • Notebook runs top to bottom
  • No hardcoded API keys
  • Cleanup cell at end

Note

Low Risk
Low risk: documentation-only notebook updates, mainly swapping Pinecone client/index initialization and response handling to match SDK v8 and improving key handling/cleanup.

Overview
Updates learn/search/question-answering/table-qa.ipynb to use the Pinecone SDK v8 API: installs pinecone, initializes a Pinecone client, creates a serverless index via ServerlessSpec, and uses the new pc.has_index/pc.Index flow.

Improves notebook safety and maintainability by sourcing the API key from PINECONE_API_KEY (with getpass fallback), updating query result access to result.matches[0].id, refreshing explanatory prose, and adding a Cleanup cell to delete the index when finished.

Written by Cursor Bugbot for commit a62ca7e. This will update automatically on new commits. Configure here.

- Replace pinecone-client with pinecone package
- Initialize client with Pinecone(api_key=...) and ServerlessSpec
- Use pc.has_index(name=...), pc.create_index(..., spec=ServerlessSpec(...)), pc.Index(name=...)
- Use result.matches[0].id for query response
- Add API key via env PINECONE_API_KEY or getpass
- Update intro to timeless language; add cleanup cell
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants