fix(learn): modernize audio-search.ipynb to Pinecone SDK v8 #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace pinecone-client with pinecone package - Use getpass fallback for API key per notebook review template
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
- Move all imports to first code cell following notebook standards - Pin dependency versions (pinecone==8.0.0, panns-inference==0.1.1, datasets==3.2.0, librosa==0.10.2) - Remove scattered import statements from individual cells Co-authored-by: Claude <[email protected]>
Collaborator
Author
|
🤖 Auto-fix attempt 5 completed at 2026-01-31T23:38:06Z |
….ipynb - Add torch to pip install dependencies (required by panns-inference) - Update Pinecone docs URL from /docs/projects to /troubleshooting/available-cloud-regions Co-authored-by: Claude <[email protected]>
- Pin torch to version 2.6.0 (required by lint checks) - Update Pinecone docs URL to working link (guides/projects/understanding-projects) - Previous URL was redirecting with 307 status, causing link checker to fail Co-authored-by: Claude <[email protected]>
The notebook was hardcoded to use CUDA device, which caused test failures in environments without GPU support. Updated to detect GPU availability and fall back to CPU when necessary. Changes: - Added torch import to cell-5 - Updated cell-15 to automatically detect and use available device - Removed hardcoded "cuda" device parameter Co-authored-by: Claude <[email protected]>
The notebook test was failing because the wget command was being filtered out by the notebook conversion script (which removes lines starting with ! or %). This caused the miaow_16k.wav file download to be skipped, leading to a FileNotFoundError when the notebook tried to load the file. Fixed by: - Replacing !wget command with urllib.request.urlretrieve() - Adding urllib.request import to the main imports cell - Maintaining the same functionality with pure Python code Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates
learn/search/audio/audio-search/audio-search.ipynbto use Pinecone SDK v8.Changes
pinecone-clientwithpineconepackage in pip installAudience / use case
Developers building audio similarity search with Pinecone (e.g. finding similar sounds, song/catalog search).
Prerequisites
Linear
Closes SDK-170
Note
Low Risk
Low risk: changes are limited to a tutorial notebook’s dependency install and Pinecone client initialization/key handling, with no impact on production code paths.
Overview
Updates
learn/search/audio/audio-search/audio-search.ipynbto use the Pinecone SDK v8 (pinecone==8.0.0) instead of the legacy client.Standardizes API key handling to prefer
PINECONE_API_KEYfrom the environment with agetpassfallback, and updates initialization topc = Pinecone(api_key=api_key)with serverless index spec configuration.Written by Cursor Bugbot for commit 498f5c5. This will update automatically on new commits. Configure here.