Skip to content

config: add CN2 Clinic endpoint - #497

Open
tao1020 wants to merge 2 commits into
pingcap:masterfrom
tao1020:fix/clinic-cn-endpoint-pingkai-20260616
Open

config: add CN2 Clinic endpoint#497
tao1020 wants to merge 2 commits into
pingcap:masterfrom
tao1020:fix/clinic-cn-endpoint-pingkai-20260616

Conversation

@tao1020

@tao1020 tao1020 commented Jun 16, 2026

Copy link
Copy Markdown

Summary

  • add CN2 as a Clinic upload region pointing to https://clinic.pingkai.cn
  • keep CN pointing to https://clinic.pingcap.com.cn
  • update CLI and Helm chart region prompts to mention CN2
  • sort dynamically loaded regions so the generated region info is deterministic

Validation

  • GOOS=darwin GOARCH=arm64 CGO_ENABLED=0 go test ./...
  • GOOS=darwin GOARCH=arm64 CGO_ENABLED=0 make check partially passed fmt, vet, and lint; check-static did not run because the Makefile installer could not find golangci-lint v2.10.1
  • CN2 upload/rebuild was validated end-to-end against Clinic CN2, with data visible in the Clinic browser panel

@pingcap-cla-assistant

pingcap-cla-assistant Bot commented Jun 16, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@tao1020
tao1020 force-pushed the fix/clinic-cn-endpoint-pingkai-20260616 branch from 54712da to 675fa2f Compare June 26, 2026 11:14
@tao1020 tao1020 changed the title config: update CN Clinic endpoint config: add CN2 Clinic endpoint Jun 26, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 8.46%. Comparing base (82f9593) to head (675fa2f).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/config/info.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #497      +/-   ##
=========================================
- Coverage   10.70%   8.46%   -2.24%     
=========================================
  Files         124     124              
  Lines       12591   10448    -2143     
=========================================
- Hits         1347     884     -463     
+ Misses      11073    9409    -1664     
+ Partials      171     155      -16     
Flag Coverage Δ
unittests 8.46% <0.00%> (-2.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants