Skip to content

i18n(ja): restore English Airbyte dropdown values (Custom format / Full refresh | Overwrite) - #23545

Open
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-airbyte-custom-format-values-2026-08-17
Open

i18n(ja): restore English Airbyte dropdown values (Custom format / Full refresh | Overwrite)#23545
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-airbyte-custom-format-values-2026-08-17

Conversation

@yahonda

@yahonda yahonda commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

Stacked on #23543 (depends on it — this PR's diff will show #23543's changes too until that one merges; once merged, this PR reduces to just its own single commit).

Found while reviewing #23543: integrate-tidbcloud-with-airbyte.md still had 4 literal Airbyte UI dropdown values left in Japanese even after Destination Namespace and Sync mode's own field-name labels were fixed to English:

  • EN: Set **Destination Namespace** to **Custom format** and set **Namespace Custom Format** to **test** to store all data in the test database.
  • EN: Choose the **Sync mode** to **Full refresh | Overwrite**.

Fixed all 4 values (Custom format, Namespace Custom Format, test, Full refresh | Overwrite) to match EN. Also rephrased the JA sentence for Sync mode from an unnatural を...に選択 construction to で...を選択 per user feedback during review.

Verified no other occurrences of these Japanese phrases exist elsewhere in the corpus.

Test plan

@ti-chi-bot

ti-chi-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hfxsd for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0454d510-6f90-4db1-8ead-d6ab3a3ad00f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 17, 2026
@yahonda
yahonda marked this pull request as ready for review August 17, 2026 06:25
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 17, 2026
…onfirmed batch)

These 228 candidate labels were skipped by the mechanical 2-word batch
(pingcap#23535) because they couldn't be confirmed via a plain dbaas-ui grep
(mostly third-party console fields — AWS, Azure, Alibaba Cloud, GCP,
Kafka, Datadog, New Relic, n8n, Airbyte, PagerDuty, Slack — which
dbaas-ui doesn't cover, plus a handful of TiDB-native labels the
grep missed). Each was individually triaged against EN (release-8.5)
and, for TiDB-native items, dbaas-ui with a strict STRONG/WEAK/
COMMENT_ONLY/NO_HIT classifier, distinguishing genuine clickable UI
elements from prose/marketing/category-header bullets that merely
share the same words (the "No cost"/"High availability" false-positive
pattern from earlier batches).

265 occurrences fixed across 47 files. ~70 further candidates were
deliberately left in Japanese as category-header/concept-heading
prose, not clickable UI (same precedent as architecture-concepts.md).

Along the way this also fixed several pre-existing defects surfaced
by the same EN comparison: mismatched AWS IAM button-label pairs
(Attach Policies vs Attach Policy treated as the same word), particle-
and bracket-trapped-in-bold spans, a word-order/position-pairing
mis-mapping (Source/Target engine, Signing method/Account key,
Export Path), a mistranslation (一般公開→Public accessible), and an
orphaned bracket left over from an incomplete straddling-bracket fix.

"Import dashboard" (monitor-new-relic-integration.md) was explicitly
skipped — already handled by pingcap#23540.
…l refresh | Overwrite

EN shows these as literal Airbyte UI dropdown values: "Set Destination
Namespace to Custom format and set Namespace Custom Format to test"
and "Choose the Sync mode to Full refresh | Overwrite." All three
values (Custom format, Namespace Custom Format, test, Full refresh |
Overwrite) were left in Japanese even after Destination Namespace and
Sync mode's own field-name labels were fixed to English elsewhere.

Also rephrased "Sync mode を Full refresh | Overwrite に選択" (unnatural
を...に選択 construction) to "Sync mode で Full refresh | Overwrite を選択"
per user feedback.

Found while reviewing pingcap#23543.
@yahonda
yahonda force-pushed the fix-airbyte-custom-format-values-2026-08-17 branch from ce6da2f to 427f56a Compare August 18, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants