i18n(ja): restore English Airbyte dropdown values (Custom format / Full refresh | Overwrite) - #23545
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…onfirmed batch) These 228 candidate labels were skipped by the mechanical 2-word batch (pingcap#23535) because they couldn't be confirmed via a plain dbaas-ui grep (mostly third-party console fields — AWS, Azure, Alibaba Cloud, GCP, Kafka, Datadog, New Relic, n8n, Airbyte, PagerDuty, Slack — which dbaas-ui doesn't cover, plus a handful of TiDB-native labels the grep missed). Each was individually triaged against EN (release-8.5) and, for TiDB-native items, dbaas-ui with a strict STRONG/WEAK/ COMMENT_ONLY/NO_HIT classifier, distinguishing genuine clickable UI elements from prose/marketing/category-header bullets that merely share the same words (the "No cost"/"High availability" false-positive pattern from earlier batches). 265 occurrences fixed across 47 files. ~70 further candidates were deliberately left in Japanese as category-header/concept-heading prose, not clickable UI (same precedent as architecture-concepts.md). Along the way this also fixed several pre-existing defects surfaced by the same EN comparison: mismatched AWS IAM button-label pairs (Attach Policies vs Attach Policy treated as the same word), particle- and bracket-trapped-in-bold spans, a word-order/position-pairing mis-mapping (Source/Target engine, Signing method/Account key, Export Path), a mistranslation (一般公開→Public accessible), and an orphaned bracket left over from an incomplete straddling-bracket fix. "Import dashboard" (monitor-new-relic-integration.md) was explicitly skipped — already handled by pingcap#23540.
…l refresh | Overwrite EN shows these as literal Airbyte UI dropdown values: "Set Destination Namespace to Custom format and set Namespace Custom Format to test" and "Choose the Sync mode to Full refresh | Overwrite." All three values (Custom format, Namespace Custom Format, test, Full refresh | Overwrite) were left in Japanese even after Destination Namespace and Sync mode's own field-name labels were fixed to English elsewhere. Also rephrased "Sync mode を Full refresh | Overwrite に選択" (unnatural を...に選択 construction) to "Sync mode で Full refresh | Overwrite を選択" per user feedback. Found while reviewing pingcap#23543.
ce6da2f to
427f56a
Compare
Summary
Stacked on #23543 (depends on it — this PR's diff will show #23543's changes too until that one merges; once merged, this PR reduces to just its own single commit).
Found while reviewing #23543:
integrate-tidbcloud-with-airbyte.mdstill had 4 literal Airbyte UI dropdown values left in Japanese even afterDestination NamespaceandSync mode's own field-name labels were fixed to English:Set **Destination Namespace** to **Custom format** and set **Namespace Custom Format** to **test** to store all data in the test database.Choose the **Sync mode** to **Full refresh | Overwrite**.Fixed all 4 values (
Custom format,Namespace Custom Format,test,Full refresh | Overwrite) to match EN. Also rephrased the JA sentence for Sync mode from an unnaturalを...に選択construction toで...を選択per user feedback during review.Verified no other occurrences of these Japanese phrases exist elsewhere in the corpus.
Test plan