Skip to content

i18n(ja): fix 14 more adjacent-bold-span defects across 13 files - #23549

Merged
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-adjacent-bold-span-batch2-2026-08-17
Aug 18, 2026
Merged

i18n(ja): fix 14 more adjacent-bold-span defects across 13 files#23549
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-adjacent-bold-span-batch2-2026-08-17

Conversation

@yahonda

@yahonda yahonda commented Aug 18, 2026

Copy link
Copy Markdown
Member

Summary

Continuation of the adjacent-bold-span defect sweep (see #23547/#23548 for the earlier two large clusters). Each of these is an EN sentence with two distinct bold terms joined by a connector word (and/or/as/to/etc.) where JA had trapped that connector word (a particle or conjunction) inside the closing/opening ** markers instead of leaving it as plain text between the two spans.

Files fixed (1 line each unless noted):

  • tidb-troubleshooting-map.md — Grafana breadcrumb (Grafana -> **TiDB** and **TiKV**)
  • auto-increment.md — unique and monotonically increasing
  • develop/dev-guide-gui-mysql-workbench.md — SQL Editor > MySQL Session
  • develop/dev-guide-create-table.md (2 lines) — primary key/clustered index, columns/primary keys
  • develop/dev-guide-sample-application-nodejs-prisma.md — "recommend" phrasing
  • develop/dev-guide-sample-application-nodejs-mysql2.md + nodejs-mysqljs.md — MUST-enable phrasing (also now matches the established corpus convention of bolding 必要があります as one unit)
  • develop/dev-guide-sample-application-ruby-mysql2.md — same MUST phrasing plus a trailing but/が particle
  • ticdc/ticdc-summary-monitor.md — Sink flush rows/s vs Puller output events/s
  • tidb-cloud/backup-and-restore.md — date and time selection (kept as a single natural 日時 term per corpus convention, particle moved outside)
  • tidb-cloud/integrate-tidbcloud-with-airbyte.md — reconstructed the "Set up source/destination" sentence into two clean quoted spans
  • tiflash/tiflash-disaggregated-and-s3.md — disaggregated vs coupled architecture
  • dashboard/dashboard-session-sso.md — reconstructed the Auth0 Client ID sentence to match this file's own established convention (OIDC クライアント ID kept as katakana, NOT English, unlike the TiDB Cloud console UI-label campaign — verified against 3 other occurrences in the same file before assuming English was correct)

Explicitly skipped (already fixed by sibling PR #23535, still open — verified via git show origin/<branch>:<file> before starting, to avoid duplicate/conflicting work): tidb-cloud/dedicated-external-storage.md (Storage Provider/Amazon S3) and tidb-cloud/data-service-get-started.md (+ Create Endpoint).

Side finding, not fixed here: while checking for conflicts, found that 5 other open PRs (#23535, #23543, #23545, #23547, #23548 — including my own #23547/#23548) are now stale against the current upstream tip (several sibling PRs merged since they were branched) and will need a rebase before they can merge cleanly. Flagging for whoever sequences the merge order; out of scope for this small fix.

Test plan

  • 0 bracket/**-parity issues in the diff (automated check)
  • Every fix verified 1:1 against EN, including checking established per-file JA conventions (e.g. dashboard-session-sso.md keeps OIDC terms in katakana)
  • Confirmed via git merge-tree that none of these 14 lines participate in any conflict with the 5 sibling branches checked

Continuation of the adjacent-bold-span defect sweep (see pingcap#23547/pingcap#23548
for the earlier two clusters). Each of these is a EN sentence with two
distinct **bold** terms joined by a connector word (and/or/as/to/etc.)
where JA had trapped that connector word (particle or conjunction)
inside the closing/opening ** markers instead of leaving it as plain
text between the two spans:

- tidb-troubleshooting-map.md: Grafana breadcrumb (-> TiDB and TiKV)
- auto-increment.md: unique and monotonically increasing
- dev-guide-gui-mysql-workbench.md: SQL Editor > MySQL Session
- dev-guide-create-table.md (x2): primary key/clustered index,
  columns/primary keys
- dev-guide-sample-application-nodejs-prisma.md: recommend phrasing
- dev-guide-sample-application-nodejs-mysql2.md +
  nodejs-mysqljs.md: MUST-enable phrasing (also matches the
  established corpus convention of bolding 必要があります as one unit)
- dev-guide-sample-application-ruby-mysql2.md: same MUST phrasing
  plus a trailing but/が particle
- ticdc-summary-monitor.md: Sink flush rows/s vs Puller output
  events/s
- tidb-cloud/backup-and-restore.md: date and time selection (kept
  as a single natural 日時 term per corpus convention, particle
  moved outside)
- tidb-cloud/integrate-tidbcloud-with-airbyte.md: reconstructed the
  Set up source/destination sentence into two clean quoted spans
- tiflash/tiflash-disaggregated-and-s3.md: disaggregated vs coupled
  architecture
- dashboard/dashboard-session-sso.md: reconstructed the Auth0
  Client ID sentence to match this file's own established
  convention (OIDC クライアント ID kept as katakana, not English,
  unlike the TiDB Cloud console UI-label campaign)

Explicitly skipped (already fixed by sibling PR pingcap#23535, still open —
verified via `git show origin/<branch>:<file>` before starting):
tidb-cloud/dedicated-external-storage.md (Storage Provider/Amazon S3)
and tidb-cloud/data-service-get-started.md (+ Create Endpoint).
@ti-chi-bot

ti-chi-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign icemap for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. area/develop This PR relates to the area of TiDB App development. labels Aug 18, 2026
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: aaf4d4f0-14c3-466d-914f-c225004decc7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 18, 2026
User feedback: bolding only the kanji stem 勧め inside the honorific
verb お勧めします (お**勧め**します) reads as unnatural mid-word emphasis
in Japanese. Bold the whole polite verb phrase instead (**お勧めします**),
matching how a single EN emphasis word (RECOMMENDED) should map to one
coherent JA unit rather than splitting the honorific prefix/stem/ending
across bold boundaries.

Fixes both occurrences of this pattern in the corpus: the one just
introduced in this PR (nodejs-prisma.md) and one pre-existing sibling
instance found via corpus grep (nodejs-typeorm.md, same EN sentence,
same defect, not otherwise touched by this PR).
@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 18, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 18, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-18 06:14:05.549462304 +0000 UTC m=+3718231.585557360: ☑️ agreed by qiancai.

@qiancai
qiancai merged commit acc868d into pingcap:i18n-ja-release-8.5 Aug 18, 2026
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants