sql: remove unnecessary 'copy' from FLUSH PRIVILEGES description - #23196
sql: remove unnecessary 'copy' from FLUSH PRIVILEGES description#23196yahonda wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the description of the FLUSH PRIVILEGES statement by changing "in-memory copy of privileges" to "in-memory privileges". The reviewer suggested further simplifying the text by removing "in-memory" entirely to avoid unnecessary words, which aligns with the style guide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1ddda69 to
cfe6984
Compare
Match MySQL's own wording ('Reloads the privileges from the grant tables'):
drop 'into memory' and state 'privileges from the grant tables', which also
addresses the review suggestion to remove the in-memory phrasing.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesFLUSH PRIVILEGES documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
What is changed, added or deleted? (Required)
Align the
FLUSH PRIVILEGESdescription with MySQL documentation. Changed:reload the in-memory copy of privileges from the privilege tablesreload the grant tables into memoryMySQL's own documentation at https://dev.mysql.com/doc/refman/8.4/en/privilege-changes.html uses
reload the grant tableswithoutcopy. TiDB documentation should follow the same concise style.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?
Summary by CodeRabbit
FLUSH PRIVILEGESdescription to clarify that TiDB reloads privileges from grant tables.