i18n(ja): add missing particle after Markdown links (wo before verbs, wa for subject) - #23273
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request systematically improves the Japanese documentation by correcting grammatical particles, specifically ensuring the proper use of 'を参照してください' and 'を使用することをお勧めします' across numerous files. The reviewer's feedback is excellent and highly actionable, identifying several remaining typos (such as stray numbers '5', '1', '17'), grammatical awkwardness, missing particles, inconsistent terminology (e.g., 'storage' vs. 'ストレージ'), and minor formatting issues. All suggested changes are accompanied by ready-to-commit code blocks to ensure high-quality, natural Japanese documentation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…ingcap#23273) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…, spaces, storage, IAM typo) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Thanks for the thorough review. To keep this PR focused on its single purpose (adding the missing particle after Markdown links), the 34 review findings have been addressed in separate PRs by kind, per our PR-splitting strategy:
These sibling PRs share some files with this one and will be rebased after the earlier PRs merge. |
7cfd082 to
6244b84
Compare
…ingcap#23273) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…, spaces, storage, IAM typo) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
a0f87a4 to
84b240b
Compare
84b240b to
452ea4b
Compare
…ingcap#23273) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…, spaces, storage, IAM typo) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…, spaces, storage, IAM typo) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
These lines are also touched by the other open ja PRs (pingcap#23272/pingcap#23273/pingcap#23274/pingcap#23275). Each PR previously applied only its own fix, so whichever merged second would conflict. Apply the union of the fixes (stray-digit removal + particle insertion) so every branch produces identical text and merges cleanly in any order. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
These lines are also touched by the other open ja PRs (pingcap#23272/pingcap#23273/pingcap#23274/pingcap#23275). Each PR previously applied only its own fix, so whichever merged second would conflict. Apply the union of the fixes (stray-digit removal + particle insertion) so every branch produces identical text and merges cleanly in any order. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
These lines are also touched by the other open ja PRs (pingcap#23272/pingcap#23273/pingcap#23274/pingcap#23275). Each PR previously applied only its own fix, so whichever merged second would conflict. Apply the union of the fixes (stray-digit removal + particle insertion) so every branch produces identical text and merges cleanly in any order. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
These lines are also touched by the other open ja PRs (pingcap#23272/pingcap#23273/pingcap#23274/pingcap#23275). Each PR previously applied only its own fix, so whichever merged second would conflict. Apply the union of the fixes (stray-digit removal + particle insertion) so every branch produces identical text and merges cleanly in any order. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
These lines are also touched by the other open ja PRs (pingcap#23272/pingcap#23273/pingcap#23274/pingcap#23275). Each PR previously applied only its own fix, so whichever merged second would conflict. Apply the union of the fixes (stray-digit removal + particle insertion) so every branch produces identical text and merges cleanly in any order. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
These lines are also touched by the other open ja PRs (pingcap#23272/pingcap#23273/pingcap#23274/pingcap#23275). Each PR previously applied only its own fix, so whichever merged second would conflict. Apply the union of the fixes (stray-digit removal + particle insertion) so every branch produces identical text and merges cleanly in any order. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
a37107f to
4c24e98
Compare
These lines are also touched by the other open ja PRs (pingcap#23272/pingcap#23273/pingcap#23274/pingcap#23275). Each PR previously applied only its own fix, so whichever merged second would conflict. Apply the union of the fixes (stray-digit removal + particle insertion) so every branch produces identical text and merges cleanly in any order. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ngCAP Support) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ingCAP Support) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ega file) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… separate PR) The particle-after-link fix on this line was entangled with an out-of-scope API-name formatting change (TiDB OperatorAPI -> TiDB Operator API). Reverting here; both are handled together in the dedicated API-name PR to keep this PR link-particle only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The particle-after-link heuristic wrongly inserted を after links whose text is itself a full verb phrase (e.g. [バグを報告する](...support), [サポートを受ける](/support.md)), producing ungrammatical "<verb>を<verb>" text such as "報告するを参照" and even "をください". Revert those を to base on ~48 lines; the redundant-trailing-verb rewrite of these support/report links is handled by a separate dedicated PR. The legitimate particle after noun links on the same lines (e.g. after [MySQLとの互換性]) is kept. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Conflicts have been addressed. |
Line-by-line review against the English release-8.5 source found three lines whose earlier repair left ungrammatical or garbled text: - clinic-introduction / troubleshoot-data-inconsistency: [サポートを受ける] followed by 選択/利用 read wrong; EN is just "you can get support" -> [サポートを受ける](/support.md)ことができます. - external-storage-uri: add dropped を after [IAMロール], and rewrite the garbled trailing external-ID sentence to match the English. Applied byte-identically in pingcap#23273 and pingcap#23274. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Keeps this line byte-identical with the fix in pingcap#23274 so the two PRs do not conflict on functions-and-operators/bit-functions-and-operators.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…lease-7.4.0 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
[LGTM Timeline notifier]Timeline:
|
What is changed, added or deleted? (Required)
This PR restores particles that were dropped immediately after Markdown links throughout the Japanese documentation, where machine translation omitted the particle between a link and the following word. It covers the whole top-level docs tree (reviewed in rounds), several subdirectories, and the large reference pages.
Main fix — missing を (object marker) before a verb:
[link text](url)使用して→[link text](url)を使用してApplied only where the link is the direct object of a transitive verb (
使用 / 実行 / 参照 / 報告 / 取得 / 指定 / 削除 / 確認 / 作成…) in an active conjugation (して / すると / する / します / した / できる …). Compound nouns such as[link]機能(which need no particle) and passiveされforms are not touched. Links whose text is itself a full verb phrase (e.g.[サポートを受ける],[バグを報告する]) are also not given a particle — see the scope note below.Also — missing は / が (topic / subject marker) where the link is the sentence subject:
[Hibernate](https://hibernate.org/orm/)人気のオープンソースJava ORMです。→…)は人気の……[store-io-pool-size](url)ONに設定されている場合…→…)がONに設定されている場合…Also — missing で / に (instrumental / target marker) where the link is the means or the target rather than the object.
Scope: ~2,388 changed lines across ~757 files, including the multi-round sweep of the top-level docs and the large reference pages (
system-variables,tikv-configuration-file,tidb-configuration-file,pd-control,optimizer-hints,sql-plan-management,sql-tuning-best-practice,latency-breakdown,statistics,alert-rules). Verified mechanically: each changed line differs from its original by the restored particle alone, except for the small number of shared lines noted below. No double particle is introduced.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?
Note on scope — lines shared with sibling ja PRs
A few lines in this PR also carry a fix that belongs to one of the sibling ja i18n PRs (a stray-digit removal, a scrambled-sentence repair, or a code-span particle). Where a later sweep found additional damage on a line this PR already edits, the union of both fixes was applied here — and made byte-identical in the sibling PR — so the two PRs stay conflict-free instead of colliding. For example:
Here the stray
1(a translation-tool placeholder) and the word order were repaired alongside this PR's particle insertion.Kept out of this PR
To keep this PR strictly to particle insertions, two things were deliberately excluded during review:
TiDB OperatorAPI→TiDB Operator API, and restoring English CRD names such asTidbCluster,TidbMonitor) was split into its own PR (i18n(ja): keep TiDB Operator API resource names in English #23367).[サポートを受ける](/support.md),[バグを報告する](…/support)) are left untouched here (they need a rewrite, not a particle) and are handled by a dedicated PR. An earlier revision of this PR had wrongly insertedをafter these links (報告するを参照…); those insertions were reverted.Rebase / merge state
This PR is rebased onto the current
i18n-ja-release-8.5(which now includes #23272) and merges cleanly. The other open ja i18n PRs are still on the earlier base and will each be rebased onto the current base in turn.