Skip to content

i18n(ja): unify "plan cache" katakana term (remove stray space) in sql-prepared-plan-cache.md - #23297

Merged
qiancai merged 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-plan-cache-spacing
Jul 29, 2026
Merged

i18n(ja): unify "plan cache" katakana term (remove stray space) in sql-prepared-plan-cache.md#23297
qiancai merged 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-plan-cache-spacing

Conversation

@yahonda

@yahonda yahonda commented Jul 16, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Unifies the Japanese term for "plan cache" in sql-prepared-plan-cache.md. The file mixed プラン キャッシュ (with a space) and プランキャッシュ (no space) for the same term. This normalizes all 10 spaced occurrences to the no-space form already used in the other 25 places in the file, which is also the repo-wide convention (331 vs 75).

Intentionally left unchanged:

  • The grammatically distinct プランのキャッシュ ("the plan's cache", 4 occurrences).
  • The English "Plan Cache" that appears in metric names (e.g. Queries Using Plan Cache OPS).

This is a Japanese (ja) translation-only fix; no English source content is changed. It follows up on a gemini-code-assist review comment on PR #23294.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Note on scope

A few of the lines in this PR also carry a fix that belongs to one of the sibling ja PRs. Where a later sweep found damage on a line this PR already edits, the fix was applied here rather than duplicated into another PR — otherwise the two PRs would conflict. So a small number of lines go beyond the scope stated above, for example:

-…発生します。1パラメータ`gc.max_write_bytes_per_sec`使用すると、…
+…発生します。`gc.max_write_bytes_per_sec`パラメータを使用すると、…

Here the stray 1 (a translation-tool placeholder) and the word order were repaired alongside this PR's particle insertion.

All fifteen ja PRs were verified to merge cleanly in any order (105 pairwise merges, 0 conflicts).

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot

ti-chi-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oreoxmt for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes the Japanese translation of "plan cache" by removing the space (changing "プラン キャッシュ" to "プランキャッシュ") in the sql-prepared-plan-cache.md file. The review feedback correctly identifies several minor grammatical issues and typos in the Japanese text, such as missing particles ("を") and unnatural phrasing ("ページ目で" instead of "ページで"), which should be addressed to improve readability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread sql-prepared-plan-cache.md Outdated
Comment thread sql-prepared-plan-cache.md Outdated
Comment thread sql-prepared-plan-cache.md Outdated
@yahonda yahonda changed the title i18n(ja): unify プランキャッシュ terminology in sql-prepared-plan-cache.md i18n(ja): unify "plan cache" katakana term (remove stray space) in sql-prepared-plan-cache.md Jul 16, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 16, 2026
@yahonda
yahonda force-pushed the i18n-ja-fix-plan-cache-spacing branch from 834eaa8 to dbfbe80 Compare July 16, 2026 08:59
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 41e1cf1e-550f-42af-b5e0-ff089736d841

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

yahonda and others added 2 commits July 24, 2026 09:49
The file mixed プラン キャッシュ (with a space) and プランキャッシュ (no space)
for the same term. Normalizes all 10 spaced occurrences to the no-space form
already used in the other 25 places in the file (and the repo-wide convention).

The grammatically distinct プランのキャッシュ (4 occurrences) and the English
"Plan Cache" (in metric names) are intentionally left unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
These lines are also touched by other open ja PRs. Each PR previously applied only
its own fix, so whichever merged second would conflict. Apply the union of the fixes
so every branch produces identical text and merges cleanly in any order.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@yahonda
yahonda force-pushed the i18n-ja-fix-plan-cache-spacing branch from a28b596 to 9164851 Compare July 24, 2026 01:03
@yahonda
yahonda marked this pull request as ready for review July 29, 2026 05:31
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 29, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-07-29 14:09:14.96092619 +0000 UTC m=+2018740.997021247: ☑️ agreed by qiancai.

@qiancai
qiancai merged commit 8fd4b6c into pingcap:i18n-ja-release-8.5 Jul 29, 2026
2 of 5 checks passed
@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants