Skip to content

i18n(ja): move mid-sentence issue links to the end of release-note bullets - #23431

Merged
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-issue-link-scramble
Aug 5, 2026
Merged

i18n(ja): move mid-sentence issue links to the end of release-note bullets#23431
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-issue-link-scramble

Conversation

@yahonda

@yahonda yahonda commented Aug 4, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Follow-up to #23423 (which fixed author-attribution @[handle] links). The machine translation also left issue/PR reference links [#NNNN] stranded in the middle of many release-note bullets, splitting the description, whereas the English source places them at the end of the bullet.

Verified 1:1 against the English source and moved the 48 genuine mid-sentence issue links to the end of their bullets, repairing the particle at the former link site (and in one case relocating a stranded code token EXECUTE to its subject position).

Left unchanged (legitimate inline references, matched to English): "changes made in [#N]" ([#N]で行われた変更), "see [#N]" ([#N]を参照), "comment on [#N]" ([#N]にコメント).

Preserved (verified): full-width (count unchanged, 103), author @[handle] links (count unchanged, 5907), URLs, indentation. Refs are attached at bullet-end in each file's dominant local style.

Scope: 48 changes across 3 files (release-5.0.2, release-5.4.3, release-6.6.0).

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Follow-up to #23423 (release-note author-link scramble fix).

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8c7d9013-eff7-46d1-9b1f-5b30442484a2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csuzhangxc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 4, 2026
@yahonda
yahonda marked this pull request as draft August 4, 2026 07:53
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2026
@yahonda
yahonda force-pushed the i18n-ja-fix-issue-link-scramble branch 3 times, most recently from a6d72ea to da18e17 Compare August 5, 2026 00:13
@yahonda
yahonda marked this pull request as ready for review August 5, 2026 00:14
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2026
…llets

Follow-up to pingcap#23423 (which fixed author-attribution links). The machine translation
also left issue/PR reference links [#NNNN] stranded in the MIDDLE of many release-note
bullets, splitting the description; the English source places them at the END of the
bullet. Verified 1:1 against the English source and moved the 48 genuine mid-sentence
issue links to the end, repairing the particle at the former link site (and, in one
case, relocating a stranded code token). Legitimate inline references ("changes made
in [#N]", "see [#N]", "comment on [#N]") are left unchanged.

Also, on the moved bullets: drop the trailing 。 after the link to match the English
source (no period) and this file's dominant bullet style; render "GORM MySQL driver"
in English (lowercase, matching the English source exactly) instead of katakana; and
restore missing subject particles found on re-review (`INL_HASH_JOIN`がハングアップする,
TiCDC がpanicする, [GORM]がTiDB統合テストを追加します, [GORMドキュメント]がTiDBを...と言及しています).
Full-width # and author @[handle] links are untouched.
@yahonda
yahonda force-pushed the i18n-ja-fix-issue-link-scramble branch from da18e17 to 8c011ae Compare August 5, 2026 00:15
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 5, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-05 12:25:12.698882292 +0000 UTC m=+2617298.734977358: ☑️ agreed by qiancai.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 5, 2026
@qiancai
qiancai merged commit dbb3c94 into pingcap:i18n-ja-release-8.5 Aug 5, 2026
5 of 9 checks passed
@yahonda
yahonda deleted the i18n-ja-fix-issue-link-scramble branch August 6, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants