ticdc: remove awkward directly from Debezium doc - #23574
Conversation
"directly ignores" is an overly literal translation of the Chinese source's "直接忽略" (docs-cn#16513) - "directly" reads as a spatial/ routing adverb in English and doesn't collocate naturally with "ignores". Dropping it reads more naturally; the preceding "only supports Row Changed events" already makes the contrast clear. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe TiCDC Debezium documentation now states that DDL and WATERMARK events are ignored without the former “directly” qualifier. ChangesTiCDC Debezium documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a localized documentation wording correction with no actionable merge-blocking risk remaining after normal checks and review. Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What is changed, added or deleted? (Required)
ticdc/ticdc-debezium.md's classic-architecture description says "the Debezium protocol only supports Row Changed events and directly ignores DDL events and WATERMARK events." "directly ignores" is an overly literal rendering of the Chinese source's "直接忽略" (docs-cn#16513) - in English, "directly" reads as a spatial/routing adverb and doesn't collocate naturally with "ignores". Dropped it; the preceding "only supports Row Changed events" already makes the contrast to the ignored event types clear.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
master(that doc has already moved past the classic/new architecture split), so master does not need this fixAI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit