i18n(ja): remove space between numbers and Japanese counters - #23578
Open
yahonda wants to merge 4 commits into
Open
i18n(ja): remove space between numbers and Japanese counters#23578yahonda wants to merge 4 commits into
yahonda wants to merge 4 commits into
Conversation
Corpus-wide, a half-width numeral immediately followed by a half-width space and a Japanese counter word (e.g. "1 つ", "3 秒", "90 秒") is inconsistent with the majority convention of no space (e.g. "1つ", "3秒", "90秒") - measured per-counter across the corpus, no-space is the clear majority for every common counter checked (つ, 件, 時間, 回, 秒, 分, 日, 年, 月, 種, 台, 人, 枚), by a wide margin for most (e.g. 年: 888 vs 104, 日: 933 vs 142). Excluded 個, where the two forms are nearly tied (94 vs 95) and thus ambiguous. Fix is a mechanical, code-fence- and inline-code-aware substitution: skips ``` fenced blocks and `inline code` spans entirely, only touching the space in plain prose. 2,103 occurrences across 625 files. Verified 0 anomalies in line-count/**-count/[-count/]-count/ backtick-count across all 625 changed files. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
test seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
ti-chi-bot
Bot
added
area/develop
|
Important Review skippedToo many files! This PR contains 636 files, which is 486 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (636)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ti-chi-bot
Bot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Follow-up to the previous commit, which removed the space between a number and its trailing counter (e.g. "2 つ" -> "2つ") but left the space before the number untouched in phrases like "次の 2つ" (the following two). Found via user review of the PR diff. Fixed the narrow, high-confidence pattern: a demonstrative/quantifier word (次の, 上記の, 以下の, 前述の, この, その, あの, 各, 全, 合計, 約, これら, それら) immediately followed by a space and a number+counter phrase (already-joined by the previous commit, e.g. 2つ, 3種, 10分). This is deliberately narrower than a blanket "remove space before any number" rule, which would also strip legitimate spaces before IP addresses, version numbers, and standalone labeled numbers (e.g. "デフォルト 127.0.0.1", "警告 3"). 204 occurrences across 143 files. Verified 0 anomalies in line-count/backtick-count/[-count across all 143 changed files. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Found via user review: "Xを N に設定する" ("set X to N") had spaces
on both sides of the bare number, e.g. "レプリカ数を 2 に設定してい
ます" -> "レプリカ数を2に設定しています". 23 occurrences across 20
files, matched narrowly (を + space + number + space + に, skipping
code spans) to avoid touching unrelated を.../に... constructions
that don't sandwich a bare number.
Verified 0 anomalies in line-count/backtick-count across all 21
changed files (20 new + 1 overlapping with the previous commit).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
yahonda
pushed a commit
to yahonda/docs
that referenced
this pull request
Aug 20, 2026
Preemptive fix to avoid a conflict with the separate number+counter spacing sweep (PR pingcap#23578) touching the same lines. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
qiancai
added
translation/no-need
# Conflicts: # best-practices/saas-best-practices.md # sql-plan-management.md # system-variables.md # tidb-cloud/explore-data-with-chat2query.md # tidb-cloud/migrate-from-mysql-using-data-migration.md # tidb-cloud/releases/release-notes-2023.md # tidb-cloud/tidb-cloud-glossary.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Corpus-wide, a half-width numeral immediately followed by a half-width space and a Japanese counter word (e.g.
1 つ,3 秒,90 秒) is inconsistent with the majority convention of no space (e.g.1つ,3秒,90秒).Measured per-counter across the corpus, no-space is the clear majority for every common counter checked:
Excluded
個, where the two forms are nearly tied (95 space vs 94 no-space) and thus ambiguous — not fixed here.Fix is a mechanical, code-fence- and inline-code-aware substitution: skips
```fenced blocks and`inline code`spans entirely, only touching the space in plain prose. 2,103 occurrences across 625 files.Verified 0 anomalies in line-count/
**-count/[-count/]-count/backtick-count across all 625 changed files.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?