i18n(ja): fix dropped particles before verbs across the corpus (batch 2) - #23611
Merged
qiancai merged 1 commit intoAug 28, 2026
Conversation
|
Important Review skippedToo many files! This PR contains 190 files, which is 40 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (190)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ti-chi-bot
Bot
added
missing-translation-status
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This was referenced Aug 27, 2026
yahonda
added a commit
that referenced
this pull request
Aug 27, 2026
55 sites across 51 files where the topic particle は appears to be missing immediately after a code span/bracket, before a definitional or state predicate (becomes/is called/represents/corresponds to/is supported/etc.). NOT individually verified against the English source per-site, unlike the previous を (#23579/#23611) and が (#23624) sweeps. は is far more context-dependent than を/が (Japanese frequently and correctly omits は when a topic is already established), so a mechanical detector has a much higher false-positive rate here. Submitted as a draft specifically so a human can review each site before merging. UPDATE: user review caught a systemic false-positive class in the になります/となります predicate category (18 sites) -- the captured code span/bracket is the COMPLEMENT (the resulting value) of the "becomes X" predicate, not its subject, e.g. "この機能が一般提供 （GA）となります" (the feature becomes GA) mis-edited to insert は right before となります, producing the ungrammatical "一般提供（GA） はとなります". All 18 sites in this predicate category were reverted; 37 sites across the other predicate categories remain.
Fixed missing particles (mostly を, a few が/は/で/に) immediately before common action verbs (設定する, 有効にする, 追加する, 実行する, 使用する, インストールする, 検索する, etc.) where a code-span, closing paren, or bracket directly touches the verb with no particle in between. Combines four parallel groups covering 190 files total. - group 0: 47 particle insertions/corrections across 42 files - group 1: ~55 particle insertions across 49 files - group 2: 71 particle insertions/fixes across 46 files - group 3: ~48 particle insertions across 51 files A number of adjacent pre-existing MT defects were also fixed alongside the flagged particles when directly confirmed against the release-8.5 EN source, including scrambled/reordered code-span lists, duplicated or wrong verbs, garbled/duplicated link text, and misplaced PR-link/terms breaking sentences. See the individual group commits on the source branch for the full per-file breakdown. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
yahonda
force-pushed
the
fix-dropped-particles-batch2-2026-08-26
branch
from
August 27, 2026 04:32
39a550a to
4f9089b
Compare
qiancai
added
translation/no-need
qiancai
approved these changes
Aug 28, 2026
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Corpus-wide sweep for sentences with a dropped particle (mainly を) immediately before a verb, following on from #23579's original pattern. Scope was expanded beyond the original ~14-verb heuristic to ~50 common verbs, and re-scanned across the whole
i18n-ja-release-8.5tree.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?