test: add test case in debezium protocol (#5606)#5607
Conversation
ti-chi-bot
added
lgtm
need-cherry-pick-release-nextgen-202603
release-note
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the integration test data in data.sql by adding a c_varchar column to the tp_time table and updating the corresponding insert statements. It also appends a new c_newcol column via an ALTER TABLE statement. The reviewer suggests improving test coverage by inserting a row with a non-null value for c_newcol to verify that non-null values in the newly added column are correctly replicated and decoded.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| alter table tp_time add column c_newcol datetime default null; | ||
|
|
||
| insert into tp_time() | ||
| values (); |
There was a problem hiding this comment.
To ensure thorough test coverage for the newly added column c_newcol after the ALTER TABLE statement, consider inserting a row with a non-null value for c_newcol. Currently, the test only inserts a row with default values (where c_newcol is NULL), which does not verify if non-null values in the newly added column are correctly replicated and decoded under the Debezium protocol.
alter table tp_time add column c_newcol datetime default null;
insert into tp_time(c_date, c_datetime, c_timestamp, c_time, c_year, c_varchar, c_newcol)
values ('2022-02-22', '2022-02-22 22:22:22', '2020-02-20 02:20:20', '02:20:20', '2021', '2021', '2022-02-22 22:22:22');
insert into tp_time()
values ();
|
/test all |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
This is an automated cherry-pick of #5606
What problem does this PR solve?
Issue Number: close #5605
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Summary by CodeRabbit