Skip to content

Let guest shares show the PR review guides for the shared thread's linked PRs #30216

Closed

Description

@stefan-garofalo

What happened

I generated a PR review guide (Guide tab, 6 stops) for a PR linked to a thread, and I want colleagues to walk through it. I share threads through guest links, but the guest page shows only the conversation, so the guide stays visible only to my own T3 Code clients.

Proposal: guest shares should include the PR panel's guide, read-only, for the PRs linked to the shared thread.

Diagnosis

Guides are already stored on the server in pull_request_review_guides, keyed by (host, repository, number). The guest share sends only GuestShareView and the thread stream items (packages/contracts/src/guestStream.ts). No guest HTTP route (apps/server/src/guest/http.ts) serves guide data, and GuestPage.tsx has no pull request UI. Read progress (guideRunStore.ts) is tracked on each viewer's client, so a guest would keep separate progress with no new storage.

Open design points:

  1. Scope: which guides a guest gets. A thread can link many PRs (mine links 6). The natural scope is guides for PRs in the thread's pullRequests.
  2. Code excerpts: stops show diff excerpts the server fetches from the forge with the owner's credentials. Showing them to guests exposes repo contents beyond the chat, so this probably needs an explicit opt-in in the share dialog.
  3. Read-only: guests should not be able to regenerate guides or use "Ask about this stop".

Steps to reproduce

  1. Link a PR to a thread and generate its review guide in the PR panel.
  2. Share the thread as a guest link.
  3. Open the link in a different browser. The conversation is there, but there is no PR panel and no guide.

Version

0.1.7-nightly.20261103.4106 (desktop on macOS, server on Linux)

Environment

Debian 13 (Linux 6.12, x64), Node v26.12.1; the guest view is served through T3 Connect

Evidence

statev2.sqlite: pull_request_review_guides has the guide row for the PR (~10 KB guide_json).
No pull-request references in apps/server/src/guest/* or apps/web/src/components/guest/*.

Related issues

None found. #26033, #27534 and #18300 are bugs in the guide itself, not this request.

Fix applied or workaround

None. Today the only way to show the guide is to screenshot the Guide tab.

Filed by

Claude Code (claude-opus-5-5), via t3 triage

Activity

  1. locked and limited conversation to collaborators on Nov 3, 2026
  2. converted this issue into a discussion #30217 on Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    via-triageFiled through npx t3 triage

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions