Add Ubuntu deb release artifact#2474
Add Ubuntu deb release artifact#2474Abhishek-Gawade-programmer wants to merge 2 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| runner: blacksmith-32vcpu-ubuntu-2404 | ||
| platform: linux | ||
| target: deb | ||
| arch: x64 |
There was a problem hiding this comment.
Duplicate artifact name causes release workflow failure
High Severity
The new Ubuntu .deb x64 matrix entry has platform: linux and arch: x64, identical to the existing Linux x64 (AppImage) entry. The artifact upload step on line 357 derives its name from desktop-${{ matrix.platform }}-${{ matrix.arch }}, so both jobs produce desktop-linux-x64. With actions/upload-artifact@v7, the second job to finish will fail because an artifact with that name already exists and no overwrite: true is set. The artifact name needs to incorporate the target to differentiate the two Linux builds.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit fbd1741. Configure here.
ApprovabilityVerdict: Needs human review CI/CD changes to add Ubuntu .deb release artifact. An unresolved high-severity review comment identifies that the new matrix entry would create duplicate artifact names with the existing Linux AppImage build, causing workflow failures. This bug should be addressed before merging. You can customize Macroscope's approvability policy. Learn more. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 009af84. Configure here.
| runner: blacksmith-32vcpu-ubuntu-2404 | ||
| platform: linux | ||
| target: deb | ||
| arch: x64 |
There was a problem hiding this comment.
Linux updater metadata collision between AppImage and deb builds
Medium Severity
Both the AppImage and deb builds will generate identically-named auto-update metadata files (latest-linux.yml or nightly-linux.yml) because resolveGitHubPublishConfig injects a publish config for all targets. When artifacts are merged via download-artifact with merge-multiple: true, one metadata file silently overwrites the other. If the deb metadata wins, AppImage auto-update users get pointed to a .deb file, breaking auto-updates. The macOS builds handle a similar multi-arch collision via manifest renaming (lines 335–340), but no equivalent handling exists for the two Linux targets.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 009af84. Configure here.


What Changed
dist:desktop:debscript for building a Linux.debartifact.debalongside the existing Linux AppImage artifact.debartifact and clarify that Linux auto-update remains AppImage-onlyWhy
Ubuntu users currently only get the AppImage artifact from the desktop release pipeline.
This keeps the existing AppImage path intact for Linux auto-update behavior, while also publishing a native
.debpackage fordirect Ubuntu installation. That keeps the change small and avoids changing the current updater assumptions.
Checklist
Note
Medium Risk
Modifies the release CI matrix and asset publishing steps; mistakes could break or delay desktop releases, but changes are additive and scoped to packaging/publishing.
Overview
Adds an Ubuntu x64
.debto the desktop release pipeline alongside the existing Linux AppImage.The GitHub Actions
release.ymlbuild matrix now runs a Linuxdebtarget and the workflow copies/uploads*.debassets into the GitHub Release. A newdist:desktop:debscript is added for local builds, and release docs are updated to note the new artifact and that Linux auto-update remains AppImage-based.Reviewed by Cursor Bugbot for commit 009af84. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add Ubuntu x64
.debartifact to the release build and publish pipeline.debtarget to the build matrix in release.yml, and includes*.debfiles in both the file-copy and GitHub release upload steps.dist:desktop:debnpm script in package.json for local.debbuilds..debis for direct installation while AppImage targets auto-update.Macroscope summarized 009af84.