Skip to content

fix(web): the workspace hint sits at the same height on every pane - #30578

Merged
maria-rcks merged 316 commits into
pingdotgg:maria/redesign/6-workspace-panesfrom
flamboh:t3/redesign-fix-workspace-hint-position
Nov 5, 2026
Merged

maria-rcks merged 316 commits into
pingdotgg:maria/redesign/6-workspace-panesfrom
flamboh:t3/redesign-fix-workspace-hint-position

Conversation

@flamboh

@flamboh flamboh commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Note

🤖 Claude Opus 5.5 on behalf of Oliver

Fix for the redesign stack, targets layer 6 (#28845).

Problem

The workspace hint (the pill that names the workspace you landed on) sat at a different height on each pane. In a chat it floated a gap above the composer, 108px above the pane's bottom. On a PR page, New tab, Settings or any other pane without a composer it sat 16px above the bottom edge.

Fix

Every pane now puts the hint at the chat's resting spot: 108px above the pane's bottom. A chat lifts it only when its composer grows taller than resting (a multi-line prompt, banners, request cards), keeping the same 12px gap, so the hint never covers the composer. That is one Math.min in the existing placement code. The pills' fallback class moves from bottom-30 to bottom-27 to match.

Checked in a local dev server with Replay threads, at 1400, 600 and 420px wide, in split panes, and through real workspace switches with reduced motion on:

Pane Before After
Chat, resting composer 108px 108px
New-thread draft 108px 108px
PR page, New tab, Settings 16px 108px
Split pane without composer 16px 108px
Chat, five-line prompt 12px above composer 12px above composer

Before / after

Captured at 1400 × 900, 2×, dark; matching bottom 300 px crops.

Before (layer 6) After
Chat with resting composer, before Chat with resting composer, after
Pull requests, before Pull requests, after
New tab, before New tab, after
Settings launcher pane beside chat, before Settings launcher pane beside chat, after

After only: five-line prompt, unsent; measured hint-to-composer gap: 12 px.

Hint above the five-line composer

Settings note: these refs open Settings as a dialog. The split capture shows the saved Settings launcher pane beside chat, with the dialog dismissed so the hint is visible. The live public PR list refreshed between refs.

Before navigation:

https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/41aadd3bfd3d98a4/before-navigation.mp4

After navigation:

https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/ad42e6111f372c7c/after-navigation.mp4

Claude Opus 5.5 in Claude Code (T3 Code)

takeover verification at 7a3a0ea

merged current main and the rewritten workspace-panes base without rebasing. kept the contributor's hint change intact and preserved both sides of the merge conflicts.

blacksmith vp run check:changed github/main passed: format, lint, knip, typecheck, 348 test files / 4,541 tests, and react compiler checks. two independent source reviews found no issues. chrome workspace navigation verified at 1400, 600 and 420px; no-composer hints rest at 108px, and narrow tall-composer cases retain a 12px gap.

all github actions checks pass and github reports no conflicts. the external Vercel – t3code-marketing status reports Deployment failed. without a log link. this remains a blocker to an all-green handoff. desktop shell and native mobile were not exercised; the hint uses the web layout shared by web and desktop.

before: new-tab workspace hint at 16px

after: new-tab workspace hint at 108px

keyboard workspace switch from chat to new tab

verified by gpt-6.1-sol in the codex harness.

maria-rcks and others added 30 commits November 4, 2026 02:40
@maria-rcks
maria-rcks force-pushed the maria/redesign/6-workspace-panes branch from 7064ff6 to 1c1f0cf Compare November 4, 2026 04:11
Yash-Singh1 and others added 4 commits November 3, 2026 22:18
Add 8 px edge padding to usage breakdown tables shared by Cost and Tokens. Align thread status text and actions to a common baseline while keeping icons centered.

Validated with check:changed, CI, usage-table before/after browser captures, and actual ThreadNow component captures at 100% and 91% CSS zoom. No behavior or calculation changes.

Model: GPT 6.1 Sol. Harness: Codex in T3 Code.
@macroscopeapp
macroscopeapp Bot dismissed their stale review November 4, 2026 04:55

Dismissing prior approval to re-evaluate 7a3a0ea

@github-actions github-actions Bot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Nov 4, 2026
@maria-rcks

Copy link
Copy Markdown
Collaborator

Note

Written by gpt-6.1-sol on behalf of Maria

merged main and the current workspace-panes base without rebasing, preserving the hint fix and both sides of the conflicts. blacksmith check:changed passes (348 test files, 4,541 tests); chrome navigation evidence is in the pr body. both independent source reviews found no issues.

all github actions checks pass, with no conflicts. the sole remaining red status is Vercel – t3code-marketing: Deployment failed. with no log link. no deployment was started.

@maria-rcks
maria-rcks force-pushed the maria/redesign/6-workspace-panes branch 2 times, most recently from 0d93d26 to 59473a2 Compare November 5, 2026 01:06
@maria-rcks
maria-rcks merged commit 14e764a into pingdotgg:maria/redesign/6-workspace-panes Nov 5, 2026
2 checks passed
@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants