Repository navigation
fix(web): the workspace hint sits at the same height on every pane - #30578
Merged
maria-rcks merged 316 commits intoNov 5, 2026
Conversation
maria-rcks
force-pushed
the
maria/redesign/6-workspace-panes
branch
from
November 4, 2026 04:11
7064ff6 to
1c1f0cf
Compare
Add 8 px edge padding to usage breakdown tables shared by Cost and Tokens. Align thread status text and actions to a common baseline while keeping icons centered. Validated with check:changed, CI, usage-table before/after browser captures, and actual ThreadNow component captures at 100% and 91% CSS zoom. No behavior or calculation changes. Model: GPT 6.1 Sol. Harness: Codex in T3 Code.
macroscopeapp
Bot
dismissed
their stale review
November 4, 2026 04:55
Dismissing prior approval to re-evaluate 7a3a0ea
Collaborator
|
Note Written by merged main and the current workspace-panes base without rebasing, preserving the hint fix and both sides of the conflicts. blacksmith check:changed passes (348 test files, 4,541 tests); chrome navigation evidence is in the pr body. both independent source reviews found no issues. all github actions checks pass, with no conflicts. the sole remaining red status is |
maria-rcks
force-pushed
the
maria/redesign/6-workspace-panes
branch
2 times, most recently
from
November 5, 2026 01:06
0d93d26 to
59473a2
Compare
maria-rcks
merged commit Nov 5, 2026
14e764a
into
pingdotgg:maria/redesign/6-workspace-panes
2 checks passed
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 Claude Opus 5.5 on behalf of Oliver
Fix for the redesign stack, targets layer 6 (#28845).
Problem
The workspace hint (the pill that names the workspace you landed on) sat at a different height on each pane. In a chat it floated a gap above the composer, 108px above the pane's bottom. On a PR page, New tab, Settings or any other pane without a composer it sat 16px above the bottom edge.
Fix
Every pane now puts the hint at the chat's resting spot: 108px above the pane's bottom. A chat lifts it only when its composer grows taller than resting (a multi-line prompt, banners, request cards), keeping the same 12px gap, so the hint never covers the composer. That is one
Math.minin the existing placement code. The pills' fallback class moves frombottom-30tobottom-27to match.Checked in a local dev server with Replay threads, at 1400, 600 and 420px wide, in split panes, and through real workspace switches with reduced motion on:
Before / after
Captured at 1400 × 900, 2×, dark; matching bottom 300 px crops.
After only: five-line prompt, unsent; measured hint-to-composer gap: 12 px.
Settings note: these refs open Settings as a dialog. The split capture shows the saved Settings launcher pane beside chat, with the dialog dismissed so the hint is visible. The live public PR list refreshed between refs.
Before navigation:
https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/41aadd3bfd3d98a4/before-navigation.mp4
After navigation:
https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/ad42e6111f372c7c/after-navigation.mp4
Claude Opus 5.5 in Claude Code (T3 Code)
takeover verification at
7a3a0eamerged current main and the rewritten workspace-panes base without rebasing. kept the contributor's hint change intact and preserved both sides of the merge conflicts.
blacksmith
vp run check:changed github/mainpassed: format, lint, knip, typecheck, 348 test files / 4,541 tests, and react compiler checks. two independent source reviews found no issues. chrome workspace navigation verified at 1400, 600 and 420px; no-composer hints rest at 108px, and narrow tall-composer cases retain a 12px gap.all github actions checks pass and github reports no conflicts. the external
Vercel – t3code-marketingstatus reportsDeployment failed.without a log link. this remains a blocker to an all-green handoff. desktop shell and native mobile were not exercised; the hint uses the web layout shared by web and desktop.verified by gpt-6.1-sol in the codex harness.