feat: add OS notifications for completed/failed tasks by yehyal · Pull Request #976 · pingdotgg/t3code

yehyal · 2026-03-12T14:41:45Z

Summary

Adds OS notifications when a task completes or fails, with a user-facing toggle and a settings test button.

Why

Addresses issue
Notifications are important for backgrounded work. This keeps users in the loop without requiring the app to stay focused.

What Changed

Added notification levels (off, important, normal, verbose) to control when OS alerts fire.
Emit OS notifications for:
- Important: approval required, user input required, task failed
- Normal: important + task completed
- Verbose: normal + task activity updates (task.started, task.progress)
Keep completion notifications separate from activity notifications to avoid duplicates.
Add the Settings test notification button.
Add/extend unit tests around notification helpers.

Levels are easy to extend by adding new activity kinds or mapping logic in nativeNotifications.ts.

Screenshots / Video

settings page

Demo video (notification firing):

t3code-preview-notification.mp4

Notes

Notifications are only sent when the app is in the background and the toggle is enabled.

Note

Add OS notifications for completed and failed tasks

Adds a NotificationLevel setting (Off, Important, Normal, Verbose) to client settings, configurable in the General settings panel with permission request and test notification support.
Implements notification logic in nativeNotifications.ts: detects app backgrounding, checks/requests browser permission, and resolves turn completion and attention notification payloads with deduplication.
Hooks notification dispatch into the event loop in __root.tsx, emitting OS notifications for task failures (Important+), completions (Normal+), approval/input requests (Important+), and progress (Verbose), only when the app is backgrounded.
Migrates legacy localStorage settings to server/client storage on the first server welcome event via migrateLocalSettingsToServer.

^{Macroscope summarized 25bcce0.}

Note

Medium Risk
Adds new background notification behavior triggered from the orchestration event loop and introduces a new persisted client setting plus a one-shot settings migration; mistakes could cause noisy/duplicate notifications or missed alerts.

Overview
Adds OS/native notifications for orchestration events when the app is backgrounded, driven by a new notificationLevel client setting (off/important/normal/verbose) that gates which task completions, failures, and activity updates generate alerts.

Introduces nativeNotifications helpers (permission checks, background detection, notification payload resolution + de-dupe) with comprehensive unit tests, wires dispatch into __root.tsx event batching/snapshot recovery, and extends the General settings panel to manage permission and send a test notification. Also adds a one-time migration to move legacy localStorage settings into the new server/client settings stores on welcome.

^{Reviewed by Cursor Bugbot for commit 25bcce0. Bugbot is set up for automated code reviews on this repo. Configure here.}

coderabbitai · 2026-03-12T14:41:59Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d3be0e05-a598-4897-acec-499bcd369678

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

juliusmarminge · 2026-03-12T20:19:11Z

+        const previous = lastSessionByThreadRef.current.get(thread.id);
+
+        // A completed/failed turn transitions from running with an activeTurnId
+        // to a session with no active turn and status ready/error.


should also notify on input/approval requested?

also maybe have the setting be more configurable than a boolean flag so users can set more granular levels of when they wanna be notified

I wanted to push out a mvp first for just task status notification, but I can definitely work on adding it for input/approval

can you give me a bit more info regarding fine tuning the notifications? some example scenarios / levels that you want to add

which style do you prefer

Codex App current style:

I will proceed with the first style, to match the current option styling like with the theme

Verbose Level Preview

Mahendradeokar · 2026-03-30T06:46:19Z

@juliusmarminge, I also want this feature in T3code. Very useful.

I believe all the requested changes have been made by @yehyal. If anything else is needed, let me know and I’ll update it.

I really want this feature in T3code!

Cc: @yehyal

AashishSinghal · 2026-04-01T14:02:40Z

Was using a similar but minimal version on my local, this seems like a good extended version of the same to have. I would love to have this in as well.

julian-gargicevich · 2026-04-01T23:55:28Z

I'd love to see this merged!

juliusmarminge · 2026-04-02T00:30:09Z

I will get this in. Just have more important stuff right now. But i have not forgotten about it!

yehyal · 2026-04-02T07:03:55Z

I'll work on resolving conflicts in mean time

luisKisters · 2026-05-02T11:26:47Z

Hey, is there any way I could help to bring this forward? I really want this feature in t3code

macroscopeapp · 2026-05-02T12:03:41Z

Approvability

Verdict: Needs human review

2 blocking correctness issues found. New feature adding OS notifications with ~1200 lines of new code introducing notification infrastructure, settings UI, and orchestration event handling. Multiple critical unresolved review comments identify bugs: undefined functions (fallbackToSnapshotRecovery, OLD_SETTINGS_KEY) that will cause runtime errors, and the notification pipeline being flagged as non-functional dead code.

^{You can customize Macroscope's approvability policy. Learn more.}

macroscopeapp · 2026-05-02T12:24:08Z

+        const events = await api.orchestration.replayEvents(recovery.getState().latestSequence);
+        if (!disposed) {
+          applyEventBatch(events);
+        }


🔴 Critical routes/__root.tsx:560

fallbackToSnapshotRecovery() is called at line 563 but is never defined in scope, so replay recovery failures throw a ReferenceError instead of falling back to snapshot recovery. Consider defining the function or replacing the call with runSnapshotRecovery("replay-failed").

Also found in 1 other location(s)

apps/web/src/hooks/useSettings.ts:298

OLD_SETTINGS_KEY is referenced on line 298 and 326 but is not defined anywhere in the visible file. This will cause a ReferenceError when migrateLocalSettingsToServer() is called.

🤖 Copy this AI Prompt to have your agent fix this:

In file apps/web/src/routes/__root.tsx around line 560: `fallbackToSnapshotRecovery()` is called at line 563 but is never defined in scope, so replay recovery failures throw a `ReferenceError` instead of falling back to snapshot recovery. Consider defining the function or replacing the call with `runSnapshotRecovery("replay-failed")`. Evidence trail: apps/web/src/routes/__root.tsx lines 551-572 (viewed at REVIEWED_COMMIT): `recoverFromSequenceGap` catch block at line 563 calls `void fallbackToSnapshotRecovery()`. `runSnapshotRecovery` is defined at line 572 with parameter `reason: "bootstrap" | "replay-failed"`. git_grep for `fallbackToSnapshotRecovery` in apps/web/src/routes/__root.tsx returns only the single call at line 563 — no definition exists. Also found in 1 other location(s): - apps/web/src/hooks/useSettings.ts:298 -- `OLD_SETTINGS_KEY` is referenced on line 298 and 326 but is not defined anywhere in the visible file. This will cause a `ReferenceError` when `migrateLocalSettingsToServer()` is called.

macroscopeapp · 2026-05-02T12:24:08Z

+    const reconcileSnapshotDerivedState = () => {
+      const threads = useStore.getState().threads;
+      const projects = useStore.getState().projects;
+      syncProjects(projects.map((project) => ({ id: project.id, cwd: project.cwd })));


🟠 High routes/__root.tsx:447

syncProjects is called with { id, cwd } objects, but syncProjects in apps/web/src/uiStateStore.ts reads project.key and project.logicalKey. Since id and key are different property names, project.key is always undefined, which corrupts the currentProjectCwdById map and breaks project ordering logic that depends on stable keys.

Suggested change

syncProjects(projects.map((project) => ({ id: project.id, cwd: project.cwd })));

syncProjects(projects.map((project) => ({ key: project.id, cwd: project.cwd })));

🤖 Copy this AI Prompt to have your agent fix this:

In file apps/web/src/routes/__root.tsx around line 447: `syncProjects` is called with `{ id, cwd }` objects, but `syncProjects` in `apps/web/src/uiStateStore.ts` reads `project.key` and `project.logicalKey`. Since `id` and `key` are different property names, `project.key` is always `undefined`, which corrupts the `currentProjectCwdById` map and breaks project ordering logic that depends on stable keys. Evidence trail: apps/web/src/routes/__root.tsx:447 — syncProjects called with `{ id: project.id, cwd: project.cwd }` apps/web/src/routes/__root.tsx:506 — same pattern apps/web/src/uiStateStore.ts:37-43 — `SyncProjectInput` interface requires `key`, `logicalKey`, `cwd` apps/web/src/uiStateStore.ts:240-242 — `syncProjects` reads `project.key` and `project.logicalKey`

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 004aa02. Configure here.}

vercel · 2026-05-04T10:24:09Z

@yehyal is attempting to deploy a commit to the Ping Labs Team on Vercel.

A member of the Team first needs to authorize it.

Add OS Notifications for completed/failed tasks

000bedd

github-actions Bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Mar 12, 2026

Merge branch 'main' into feat/notifications

7de3609

yehyal marked this pull request as ready for review March 12, 2026 15:37

juliusmarminge requested changes Mar 12, 2026

View reviewed changes

Comment thread apps/web/src/routes/_chat.settings.tsx Outdated

Merge branch 'main' into feat/notifications

dadf2b2

github-actions Bot added the size:L 100-499 changed lines (additions + deletions). label Mar 12, 2026

yehya-allawand and others added 2 commits March 12, 2026 21:11

Moved Notification Logic to named hook

e969db5

Merge branch 'main' into feat/notifications

0a1e63b

yehyal requested a review from juliusmarminge March 12, 2026 20:16

juliusmarminge requested changes Mar 12, 2026

View reviewed changes

UtkarshUsername mentioned this pull request Mar 16, 2026

Add system notifications + sounds #1131

Closed

yehyal and others added 2 commits March 16, 2026 12:46

Merge branch 'main' into feat/notifications

08403e5

Added Granular Notification Levels

97ab906

github-actions Bot added size:XL 500-999 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Mar 16, 2026

Merge branch 'main' into feat/notifications

0e21153

yehyal requested a review from juliusmarminge March 16, 2026 16:14

yehya-allawand and others added 4 commits March 16, 2026 17:22

format fix

bbd7049

Merge branch 'main' into feat/notifications

a6d5943

Merge branch 'main' into feat/notifications

c4e2d82

fix merge conflict

f0d8767

yehya-allawand added 2 commits April 2, 2026 09:00

Merge origin/main into feat/notifications

c113c9a

fix formatting

691c775

Resolving Merge Conflicts

5b410af

github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels May 2, 2026

Merge branch 'main' into feat/notifications

23f2bea

github-actions Bot added size:XL 500-999 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels May 2, 2026

macroscopeapp Bot reviewed May 2, 2026

View reviewed changes

Comment thread packages/contracts/src/settings.ts Outdated

cursor Bot reviewed May 2, 2026

View reviewed changes

Comment thread packages/contracts/src/settings.ts Outdated

Comment thread apps/web/src/routes/__root.tsx

Resolving Merge Conflicts

2b5b1db

macroscopeapp Bot reviewed May 2, 2026

View reviewed changes

cursor Bot reviewed May 2, 2026

View reviewed changes

Comment thread apps/web/src/routes/__root.tsx

Merge branch 'main' into feat/notifications

004aa02

cursor Bot reviewed May 2, 2026

View reviewed changes

Comment thread apps/web/src/routes/__root.tsx

Merge branch 'main' into feat/notifications

25bcce0

	syncProjects(projects.map((project) => ({ id: project.id, cwd: project.cwd })));
	syncProjects(projects.map((project) => ({ key: project.id, cwd: project.cwd })));

Conversation

yehyal commented Mar 12, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

What Changed

Screenshots / Video

Notes

Add OS notifications for completed and failed tasks

Uh oh!

coderabbitai Bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

juliusmarminge Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

yehyal Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

yehyal Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

yehyal Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

yehyal Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

Mahendradeokar commented Mar 30, 2026

Uh oh!

AashishSinghal commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

julian-gargicevich commented Apr 1, 2026

Uh oh!

juliusmarminge commented Apr 2, 2026

Uh oh!

yehyal commented Apr 2, 2026

Uh oh!

luisKisters commented May 2, 2026

Uh oh!

macroscopeapp Bot commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macroscopeapp Bot May 2, 2026

Choose a reason for hiding this comment

Uh oh!

macroscopeapp Bot May 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vercel Bot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

yehyal commented Mar 12, 2026 •

edited by cursor Bot

Loading

coderabbitai Bot commented Mar 12, 2026 •

edited

Loading

AashishSinghal commented Apr 1, 2026 •

edited

Loading

macroscopeapp Bot commented May 2, 2026 •

edited

Loading