Repository navigation
test/core: Validate customTimeoutErrorScreen settings export - #153
Merged
Merged
Conversation
Adds TestDaVinciFlowTimeoutScreenSettings_ProcessorAndHCL, which drives the real flow.yaml definition with a v0.13.0 DaVinciFlowResponse carrying the four new settings fields through ProcessResource and the HCL formatter, proving they export as optional (non-skipped) attributes. Follow-up to #152 / #144. Co-Authored-By: Claude Code <noreply@anthropic.com>
Regression Test Results
✅ No regressions detectedAll export configurations produced compatible output. Generated by regression workflow • View run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #152 (fixes #144).
Summary
You're right that #152 shipped with no validating test — the four new
custom_timeout_error_screen_*attributes were declared inflow.yamland exercised only by the generic definition validator. This PR addsTestDaVinciFlowTimeoutScreenSettings_ProcessorAndHCLininternal/core/davinci_flow_outcomes_test.go, following the existing outcomes-test pattern:DaVinciFlowResponse(v0.13.0) with the four new settings fields set, including the plain-*boolUseCustomTimeoutErrorScreen(deliberate coverage — most otheruse*settings are choice wrappers, this one is not).ProcessResourceagainst the realflow.yaml(loaded viaschema.Registry, not a synthetic schema), asserting all four values land insettings.settingsblock — i.e. the computed-skip guard does not drop them (they are optional, not computed, on the provider).=within a block; pinning exact spacing would be brittle.Tests
TestDaVinciFlowTimeoutScreenSettings_ProcessorAndHCL(new).go test ./... -count=1— all packages pass, including the previously flakyTestResolveEmbeddedReferences_DisambiguatedName_StableAcrossEnvironments.gofmtclean,go vet ./internal/core/clean.Breaking changes
None — test-only.
🤖 Generated with Claude Code