feat: add hook to sorting selected options on open with enable flag #43
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { useEffect, useMemo, useState } from 'react' | ||
|
|
||
| export function useSortedOptionsOnOpen<T extends { id: string | number }>( | ||
| isOpen: boolean, | ||
| options: T[], | ||
| selectedItems: T[], | ||
| enable: boolean = true | ||
| ): T[] { | ||
| const [snapshotIds, setSnapshotIds] = useState<Set<string | number>>(new Set()) | ||
|
|
||
| useEffect(() => { | ||
| if (enable && isOpen) { | ||
| setSnapshotIds(new Set(selectedItems.map(item => item.id))) | ||
| } | ||
| }, [isOpen, enable]) | ||
|
|
||
| return useMemo(() => { | ||
| if (!enable || !isOpen) return options | ||
|
|
||
| const selected = options.filter(opt => snapshotIds.has(opt.id)) | ||
| const unselected = options.filter(opt => !snapshotIds.has(opt.id)) | ||
|
3em marked this conversation as resolved.
|
||
|
|
||
| return [...selected, ...unselected] | ||
| }, [options, snapshotIds, isOpen, enable]) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| import { useEffect, useRef, useState } from 'react' | ||
|
|
||
| export interface UseFetchOptionsParams<T> { | ||
| searchValue: string | ||
| fetchOptions: (query: string) => Promise<T[]> | ||
| } | ||
|
|
||
| export interface UseFetchOptionsResult<T> { | ||
| options: T[] | ||
| isLoading: boolean | ||
| error: Error | null | ||
| } | ||
|
|
||
| export function useFetchOptions<T>({ searchValue, fetchOptions }: UseFetchOptionsParams<T>): UseFetchOptionsResult<T> { | ||
| const [options, setOptions] = useState<T[]>([]) | ||
| const [isLoading, setLoading] = useState(false) | ||
| const [error, setError] = useState<Error | null>(null) | ||
|
|
||
| const abortControllerRef = useRef<AbortController | null>(null) | ||
|
|
||
| useEffect(() => { | ||
| if (abortControllerRef.current) { | ||
| abortControllerRef.current.abort() | ||
| } | ||
|
|
||
| const controller = new AbortController() | ||
| abortControllerRef.current = controller | ||
|
|
||
| const fetchData = async () => { | ||
| setLoading(true) | ||
| setError(null) | ||
|
|
||
| try { | ||
| const result = await fetchOptions(searchValue) | ||
| if (!controller.signal.aborted) { | ||
| setOptions(result) | ||
| } | ||
| } catch (err) { | ||
| if (!controller.signal.aborted) { | ||
| setError(err instanceof Error ? err : new Error('Unknown error')) | ||
| setOptions([]) | ||
| } | ||
| } finally { | ||
| if (!controller.signal.aborted) { | ||
| setLoading(false) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| fetchData() | ||
|
|
||
| return () => { | ||
| controller.abort() | ||
| } | ||
| }, [searchValue, fetchOptions]) | ||
|
|
||
| return { | ||
| options, | ||
| isLoading, | ||
| error | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { useMemo } from 'react' | ||
|
|
||
| export interface Option { | ||
| id: string | number | ||
| label: string | ||
| } | ||
|
|
||
| export function useFilteredOptions<T extends Option>(options: T[], searchQuery: string): T[] { | ||
| return useMemo(() => { | ||
| const search = searchQuery.trim().toLowerCase() | ||
|
|
||
| if (!search) return options | ||
|
|
||
| return options.filter(option => option.label.toLowerCase().includes(search)) | ||
| }, [options, searchQuery]) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can avoid using
useEffecthere — especially sinceselectedItemsmight not be updated at the right time.You already have the
onOpenChangeevent onDropdownMenu.Root.