Conversation
fbrehm
commented
May 12, 2026
fbrehm
commented
Member
- Adding check script check-dns-zone.sh for checking validity of the SOA of a DNS zone and optional the validity of the DNSSEC RRSIG if the SOA record.
- Adding three unit test scripts for Python modules.
- Fixing command line evaluation in update-env.sh
cruelsmith
requested changes
May 12, 2026
cruelsmith
left a comment
cruelsmith
left a comment
Contributor
There was a problem hiding this comment.
Replacing some dependencies with bash / coreutils alternatives.
Still some todo for the awk replacement.
| cmd+="\"@${SERVER}\" " | ||
| fi | ||
|
|
||
| cmd+="SOA +nocomments +noadditional +nocmd +noquestion" |
Contributor
There was a problem hiding this comment.
Optional alternative but that would need to adjust the content filter.
Suggested change
| cmd+="SOA +nocomments +noadditional +nocmd +noquestion" | |
| cmd+="SOA +short +identify" |
|
|
||
| server=$( echo "${response}" | grep -P -i '^;; SERVER:' | sed -e 's/^;; SERVER:[ ][ ]*//i' ) | ||
|
|
||
| if echo "${response}" | grep -P -q -i "^${ZONE}\\.\\s.*\\ssoa\\s" ; then |
Contributor
There was a problem hiding this comment.
Optional: convert into bash regex matching
* replace awk by date from coreutils * using bash for substring and replacement * fix handling in case of missing rrsig responce
cruelsmith
approved these changes
May 12, 2026
Contributor
|
Based on https://doc.powerdns.com/authoritative/dnssec/modes-of-operation.html#signatures
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.