PoC : regex/s are vulnerable for validation#53
Open
Lukmanern wants to merge 2 commits intopkg-id:mainfrom
Open
PoC : regex/s are vulnerable for validation#53Lukmanern wants to merge 2 commits intopkg-id:mainfrom
Lukmanern wants to merge 2 commits intopkg-id:mainfrom
Conversation
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=======================================
Coverage 91.61% 91.61%
=======================================
Files 13 13
Lines 465 465
=======================================
Hits 426 426
Misses 30 30
Partials 9 9 ☔ View full report in Codecov by Sentry. |
josestg
reviewed
Sep 28, 2023
Member
There was a problem hiding this comment.
Can you resolve the issue as well, @Lukmanern ? In my opinion, you can put these fuzzy tests into a test file, mas.
Author
|
I can, I will resolve ASAP, in 4/5 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR : request to remove some regex-base validation, like email regex validation.
Background : So many CVE's cause by Regex (See : https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=regex )
note : user@example.com. (with dot in the end) is valid email for regex validation.