Repository navigation
Listbox value setter v2 - #42
Merged
Merged
Conversation
A native <select> fires both input and change when the user picks an option, and so does the combobox (notifyFormChange). The listbox only fired input, so listeners for change never saw a selection. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Client code had to click Prima's internal option elements to change a listbox's value without a server round-trip, e.g. to reset a row that a separate hook hides. The hook now handles a prima:listbox:set-value event, and Prima.Listbox.JS.set_value/2,3,4 dispatches it from templates. Like setting .value on a native <select>, it fires no events unless notify: true is passed. Disabled options can be set; values with no matching option are ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Shows Prima.Listbox.JS.set_value resetting a role picker, and updates the form integration copy now that selections dispatch change as well as input. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Covers the prima:listbox:set-value event and Prima.Listbox.JS.set_value: value, label and marker updates, disabled options and listboxes, ignored unknown values, and which events fire with and without notify. The form tests check that input + change still count as a single phx-change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closed
ukutaht
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A second stab at Listbox value setter. Needed a rebase + a bunch of requested changes from the review so decided to open a new PR instead.
For more context see v1 PR: #33