Skip to content

Conversation

@abstrakt8
Copy link
Contributor

What was changed?

@abstrakt8 abstrakt8 requested a review from Copilot December 23, 2025 17:23
@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2025

🦋 Changeset detected

Latest commit: 596dcc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@playcanvas/react Patch
@playcanvas/blocks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 23, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@playcanvas/blocks@299
npm i https://pkg.pr.new/@playcanvas/react@299

commit: 596dcc9

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #297 by adding custom handling for the unified property of the GSplat component, which cannot be modified while the component is enabled due to PlayCanvas engine constraints.

Key Changes:

  • Added a custom apply function for the unified property that temporarily disables the component when needed to modify this restricted property
  • The implementation checks if the component is already disabled before toggling, avoiding unnecessary operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@abstrakt8 abstrakt8 self-assigned this Dec 29, 2025
@abstrakt8 abstrakt8 marked this pull request as ready for review December 29, 2025 13:35
@abstrakt8 abstrakt8 requested a review from a team December 29, 2025 13:42
@abstrakt8 abstrakt8 merged commit e564a0e into main Dec 29, 2025
6 checks passed
@abstrakt8 abstrakt8 deleted the gsplat-unified branch December 29, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GSplat unified flag not set correctly preventing LODs to be rendered correctly

3 participants