Skip to content

Android fixes - #923

Draft
brocollie08 wants to merge 3 commits into
mainfrom
1.0-android-fixes
Draft

Android fixes#923
brocollie08 wants to merge 3 commits into
mainfrom
1.0-android-fixes

Conversation

@brocollie08

@brocollie08 brocollie08 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs
📦 Published PR as canary version: 1.0.2--canary.923.40951

Try this version out locally by upgrading relevant packages to 1.0.2--canary.923.40951

@brocollie08 brocollie08 added the patch Increment the patch version when merged label Jul 30, 2026
@intuit-svc

intuit-svc commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

Comparison against baseline from main. ⚠️ = regression (>10% slower), ✅ = improvement (>5% faster)

core/player

Benchmark Current Baseline Change
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.bar 892.24K ops/s 498.13K ops/s +79.1% ✅
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.pets.1.name 524.94K ops/s 298.47K ops/s +75.9% ✅
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.pets.01.name 496.58K ops/s 322.55K ops/s +54.0% ✅
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.pets['01'].name 472.08K ops/s 433.46K ops/s +8.9% ✅
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.pets[01].name 518.44K ops/s 433.53K ops/s +19.6% ✅
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.pets[name = "frodo"].type 299.96K ops/s 264.95K ops/s +13.2% ✅
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.pets["name" = "sprinkles"].type 241.32K ops/s 224.33K ops/s +7.6% ✅
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.pets["isDog" = false].type 307.88K ops/s 275.54K ops/s +11.7% ✅
core/player/src/binding/__tests__/parser.bench.ts > parser benchmarks > Resolving binding: foo.pets["isDog" = true].type 306.89K ops/s 293.98K ops/s +4.4%
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.bar 610.88K ops/s 606.45K ops/s +0.7%
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.pets.1.name 404.16K ops/s 397.22K ops/s +1.7%
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.pets.01.name 382.19K ops/s 388.79K ops/s -1.7%
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.pets['01'].name 343.34K ops/s 342.25K ops/s +0.3%
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.pets[01].name 354.70K ops/s 290.56K ops/s +22.1% ✅
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.pets[name = "frodo"].type 221.80K ops/s 197.83K ops/s +12.1% ✅
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.pets["name" = "sprinkles"].type 187.28K ops/s 134.56K ops/s +39.2% ✅
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.pets["isDog" = false].type 218.55K ops/s 188.71K ops/s +15.8% ✅
core/player/src/binding/__tests__/parser.bench.ts > binding creation benchmarks > Resolving binding: foo.pets["isDog" = true].type 222.06K ops/s 209.10K ops/s +6.2% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = 1 + 3 (sync) 468.34K ops/s 360.37K ops/s +30.0% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = 1 + 3 (async) 339.59K ops/s 302.45K ops/s +12.3% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: conditional(true, true, false) (sync) 487.05K ops/s 299.54K ops/s +62.6% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: conditional(true, true, false) (async) 420.52K ops/s 365.52K ops/s +15.0% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = conditional({{bar}} > 0, true, false) (sync) 213.52K ops/s 199.36K ops/s +7.1% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = conditional({{bar}} > 0, true, false) (async) 158.48K ops/s 160.97K ops/s -1.6%
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = conditional(conditional(true = false, false, true), conditional(false = false, true, false), conditional(true = true, false, true)) (sync) 158.50K ops/s 126.03K ops/s +25.8% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = conditional(conditional(true = false, false, true), conditional(false = false, true, false), conditional(true = true, false, true)) (async) 140.11K ops/s 87.18K ops/s +60.7% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = await(asyncTestFunction(1)) (sync) N/A N/A N/A
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = await(asyncTestFunction(1)) (async) 296.32K ops/s 170.69K ops/s +73.6% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = asyncTestFunction(1) (sync) 340.81K ops/s 250.80K ops/s +35.9% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = asyncTestFunction(1) (async) 301.92K ops/s 190.72K ops/s +58.3% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: asyncTestFunction(1) (sync) 882.02K ops/s 491.49K ops/s +79.5% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: asyncTestFunction(1) (async) 633.22K ops/s 376.51K ops/s +68.2% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = conditional(!{{bar}} == false, await(asyncTestFunction(1)), false) (sync) 185.14K ops/s 116.36K ops/s +59.1% ✅
core/player/src/expressions/__tests__/performance.bench.ts > Expression Parsing/Execution Benchmark > Parsing: {{foo}} = conditional(!{{bar}} == false, await(asyncTestFunction(1)), false) (async) 170.82K ops/s 116.39K ops/s +46.8% ✅
core/player/src/view/resolver/__tests__/index.bench.ts > resolver benchmarks > initial resolve 628.97 ops/s 465.08 ops/s +35.2% ✅
core/player/src/view/resolver/__tests__/index.bench.ts > resolver benchmarks > Resolving from cache 18.59K ops/s 15.40K ops/s +20.7% ✅
core/player/src/view/resolver/__tests__/index.bench.ts > resolver benchmarks > data changes 2.84K ops/s 2.68K ops/s +5.9% ✅
core/player/src/view/resolver/__tests__/index.bench.ts > resolver benchmarks > data changes slow 583.91 ops/s 524.50 ops/s +11.3% ✅

plugins/async-node/core

Benchmark Current Baseline Change
plugins/async-node/core/src/__tests__/index.bench.ts > async node benchmarks > Resolve Async Node 1 times 13.77K ops/s 8.43K ops/s +63.3% ✅
plugins/async-node/core/src/__tests__/index.bench.ts > async node benchmarks > Resolve Async Node 5 times 13.77K ops/s 7.76K ops/s +77.4% ✅
plugins/async-node/core/src/__tests__/index.bench.ts > async node benchmarks > Resolve Async Node 10 times 9.74K ops/s 7.05K ops/s +38.3% ✅
plugins/async-node/core/src/__tests__/index.bench.ts > async node benchmarks > Resolve Async Node 50 times 2.52K ops/s 2.12K ops/s +19.0% ✅
plugins/async-node/core/src/__tests__/index.bench.ts > async node benchmarks > Resolve Async Node 100 times 1.39K ops/s 1.21K ops/s +14.7% ✅
plugins/async-node/core/src/__tests__/transform.bench.ts > async transform benchmarks > Resolve Async Node 1 times 7.93K ops/s 4.53K ops/s +75.2% ✅
plugins/async-node/core/src/__tests__/transform.bench.ts > async transform benchmarks > Resolve Async Node 5 times 8.60K ops/s 6.37K ops/s +34.9% ✅
plugins/async-node/core/src/__tests__/transform.bench.ts > async transform benchmarks > Resolve Async Node 10 times 7.72K ops/s 4.49K ops/s +72.0% ✅
plugins/async-node/core/src/__tests__/transform.bench.ts > async transform benchmarks > Resolve Async Node 50 times 2.87K ops/s 1.81K ops/s +57.9% ✅
plugins/async-node/core/src/__tests__/transform.bench.ts > async transform benchmarks > Resolve Async Node 100 times 1.63K ops/s 1.12K ops/s +45.4% ✅

react/player ⚠️

Benchmark Current Baseline Change
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Render asset nested in 1 ReactAssets 556.23 ops/s 464.64 ops/s +19.7% ✅
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Bubble errors nested in 1 ReactAssets 952.54 ops/s 744.86 ops/s +27.9% ✅
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Render asset nested in 5 ReactAssets 527.57 ops/s 461.46 ops/s +14.3% ✅
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Bubble errors nested in 5 ReactAssets 947.55 ops/s 679.18 ops/s +39.5% ✅
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Render asset nested in 10 ReactAssets 518.44 ops/s 468.50 ops/s +10.7% ✅
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Bubble errors nested in 10 ReactAssets 410.54 ops/s 563.74 ops/s -27.2% ⚠️
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Render asset nested in 50 ReactAssets 303.29 ops/s 379.43 ops/s -20.1% ⚠️
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Bubble errors nested in 50 ReactAssets 127.09 ops/s 190.07 ops/s -33.1% ⚠️
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Render asset nested in 100 ReactAssets 248.16 ops/s 289.68 ops/s -14.3% ⚠️
react/player/src/asset/__tests__/index.bench.tsx > ReactAsset benchmarks > Bubble errors nested in 100 ReactAssets 73.01 ops/s 80.66 ops/s -9.5%

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (50dc96e) to head (ce8d66f).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #923   +/-   ##
===========================
===========================

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@intuit-svc

intuit-svc commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Build Preview

Your PR was deployed by CircleCI #40951 on Fri, 07 Aug 2026 02:34:52 GMT with this version:

1.0.2--canary.923.40951

📖 Docs (View site)

@brocollie08

Copy link
Copy Markdown
Contributor Author

/canary

1 similar comment
@nancywu1

nancywu1 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

/canary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants