Skip to content

Monitoring subagent robustness - #4471

Merged
michaeljguarino merged 14 commits into
masterfrom
monitoring-fixes
Oct 10, 2026
Merged

michaeljguarino merged 14 commits into
masterfrom
monitoring-fixes

Conversation

@michaeljguarino

@michaeljguarino michaeljguarino commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Saw a few failures in monitor creation, this should plug gaps + add regression tests

Test Plan

Test environment: https://console.plrldemo.onplural.sh/cd/clusters/a1748282-ce8b-48ab-ae7e-326e74fce04e/services/f3f89a54-d1a7-4bc8-9152-daa07ede918d/components

Checklist

  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have deployed the agent to a test environment and verified that it works as expected (required only when changing agent code).

Plural Flow: console

@michaeljguarino
michaeljguarino requested a review from a team October 5, 2026 19:09
@michaeljguarino michaeljguarino added the enhancement New feature or request label Oct 5, 2026
@soffi-ai

soffi-ai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Soffi AI Summary

This PR hardens the monitoring subagent by closing gaps that caused failures during monitor creation, and adds regression tests to prevent regressions. It also delivers a set of targeted improvements across the observability stack and workbench configuration: Loki and Prometheus query backends gain gzip compression support and time-range-aware label queries; the AI workbench infrastructure schema gets a new selfService configuration field; MCP server initialization is reworked for reliability; the agent harness base image now supports Python; and a new Plural telemetry chart is added to support migration to Plural's own telemetry pipeline. Several UI visual regressions and edge-case bugs are also fixed.

Changes

Monitoring subagent robustness

  • Plugs gaps that caused failures during monitor creation in the monitoring subagent and adds regression tests to prevent recurrence. (a3c04dc)
  • Fixes edge cases in monitor-related logic that caused intermittent failures in the monitoring subagent. (b174e77)

Self-service workbench configuration

  • Adds a selfService field to the workbench infrastructure configuration schema across the Go client, CRD types, generated deepcopy, CRD YAML manifests, and GraphQL fragment — enabling workbenches to be configured with self-service infrastructure access. (c745b5e)

Prometheus and Loki gzip compression

  • Enables gzip compression for Loki and Prometheus query responses in the cloud-query tool providers, reducing bandwidth for large observability payloads. (35fffac)
  • Improves Prometheus range alignment to produce better-aligned time windows for metric queries. (b51fdf4)
  • Adds time-range support to Prometheus and Loki label search queries in the cloud-query tool provider, with accompanying tests. (4d5342e)

Visual regression fix

  • Fixes a visual regression in the UI introduced by a prior change. (6607dcb)
  • Follow-up cleanup and de-janking of recent UI fixes. (f53e2ab)
  • Additional UI tweaks and refinements following the visual regression fix passes. (faaa500)

Python support in agent harness

  • Allows Python to be used in the agent runtime by updating the agent-harness base Dockerfile to include Python tooling. (0fdd4a1)
  • Fixes the Python Dockerfile configuration for the agent harness following the initial Python support addition. (a2c050f)

Public dashboard fixes

  • Addresses bugs in public dashboard rendering and access. (50d316e)

MCP server initialization rework

  • Reworks MCP server initialization to be more reliable, and adds a new Helm telemetry chart template plus Helm chart secrets and values to support migration to Plural's own telemetry pipeline. (875d4ba)

Updated: 2026-10-10 15:23 UTC

Deploy in Soffi

@greptile-apps

greptile-apps Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 3/5

[High risk] Database schema changes and monitoring tool validation hardening.

The PR should not merge until the malformed-UUID tests pass and the prompt migration can be safely rolled back.

Findings

  1. P1 Malformed UUID tests will fail ▶
  2. P1 Rollback shrinks existing prompts ▶

Summary

The PR adds UUID and length validation to workbench monitoring tools, guards query validation when monitor type is missing, and widens stored descriptions.

  • The new malformed-UUID tests assert errors the changed validation path does not produce.
  • The migration specifies an incorrect prior size for monitors.prompt, making rollback unsafe for longer existing prompts.

Reviews (1) · Last reviewed commit: "Monitoring subagent robustness"

def changeset(model, attrs) do
model
|> cast(attrs, [:monitor_id])
|> check_uuid(:monitor_id)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Malformed UUID tests will fail

When monitor_id is "console", the :binary_id cast rejects it before check_uuid/2 can inspect it. The changeset therefore cannot produce the "is not a valid UUID, got console" error asserted by the new tests. The same pattern affects the service ID and the changed monitor and dashboard lookup tools, so these regression tests block the test workflow.

@michaeljguarino

Copy link
Copy Markdown
Member Author

plural deploy this

@plural-copilot

plural-copilot Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

GitOps deployment follow-up: pluralsh/plrl-up-demos#3144 pins Console to sha-d211b98 for source commit d211b988823bc3f7ffcdb4c07d650b7a9db78ee7.

@michaeljguarino
michaeljguarino requested a review from a team as a code owner October 6, 2026 02:43
@michaeljguarino

Copy link
Copy Markdown
Member Author

plural deploy this

@plural-copilot

plural-copilot Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Deployment promotion created for current head 2843134: https://github.com/pluralsh/plrl-up-demos/pull/3145

This PR includes Plural Service: mgmt/apps so the parent service can reconcile the Console CRD after merge.

@michaeljguarino

Copy link
Copy Markdown
Member Author

plural deploy this

@plural-copilot plural-copilot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaeljguarino

Copy link
Copy Markdown
Member Author

plural deploy this

@plural-copilot

plural-copilot Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

The requested demo deployment PR has been created: https://github.com/pluralsh/plrl-up-demos/pull/3161

@michaeljguarino
michaeljguarino force-pushed the monitoring-fixes branch 2 times, most recently from 62ed860 to 43a5fa2 Compare October 9, 2026 16:07
@michaeljguarino

Copy link
Copy Markdown
Member Author

plural deploy this

@plural-copilot

plural-copilot Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Requested Console promotion to sha-2c463f6 has been prepared: https://github.com/pluralsh/plrl-up-demos/pull/3162

@michaeljguarino

Copy link
Copy Markdown
Member Author

plural deploy this

@plural-copilot plural-copilot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment prepared for source SHA 65fa5d5602f5d802afb6efe585dc217f1e3b6a71 using Console tag sha-65fa5d5.

Deployment GitOps PR: https://github.com/pluralsh/plrl-up-demos/pull/3163

Deployment PR annotation: Plural Service: mgmt/apps.

@michaeljguarino

Copy link
Copy Markdown
Member Author

plural deploy this

@plural-copilot plural-copilot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment PR: https://github.com/pluralsh/plrl-up-demos/pull/3164

Promotes the requested head 1ea290def1f9a3b015716d5e3e41003ce2f76d78 as image tag sha-1ea290d.

@michaeljguarino

Copy link
Copy Markdown
Member Author

plural deploy this

@plural-copilot plural-copilot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaeljguarino

Copy link
Copy Markdown
Member Author

plural deploy this

@plural-copilot

plural-copilot Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

The requested deployment PR has been created: https://github.com/pluralsh/plrl-up-demos/pull/3168

Deployed desired Console tag: sha-b1bc19b
Source SHA: b1bc19b9f93b06879a9e3ba3a0e16a8abbf0f9ba

@plural-copilot plural-copilot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up: Console and cloud-query were pinned to sha-b2525ab (PR #4471 HEAD b2525aba61a168160c5794bbaeb2c1ba0662bc5d) in the deployment GitOps PR: https://github.com/pluralsh/plrl-up-demos/pull/3178.

The GitOps PR is awaiting normal review, merge, and reconciliation.

@michaeljguarino

Copy link
Copy Markdown
Member Author

plural deploy this

@plural-copilot

Copy link
Copy Markdown
Contributor

Deployment GitOps PR created: https://github.com/pluralsh/plrl-up-demos/pull/3179

@michaeljguarino

Copy link
Copy Markdown
Member Author

plural deploy this

@plural-copilot

Copy link
Copy Markdown
Contributor

The requested Console deployment promotion has been opened: https://github.com/pluralsh/plrl-up-demos/pull/3181

@michaeljguarino

Copy link
Copy Markdown
Member Author

plural deploy this

@plural-copilot

Copy link
Copy Markdown
Contributor

Deployment handoff: GitOps PR deploys current head c2696b0bf17617f0ac5e4e64fa08a99c4d425f40 as sha-c2696b0.

@michaeljguarino

Copy link
Copy Markdown
Member Author

plural deploy this

@plural-copilot

Copy link
Copy Markdown
Contributor

Deployment PR created for Console commit 50d316e: https://github.com/pluralsh/plrl-up-demos/pull/3184

@michaeljguarino

Copy link
Copy Markdown
Member Author

plural deploy this (and update observability proxy to the same tag too)

@plural-copilot plural-copilot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitOps deployment PR: https://github.com/pluralsh/plrl-up-demos/pull/3187

It updates Console and observability-proxy to sha-875d4ba from source head 875d4bacf273e9c867f10d304a2c68da249c1568. Merge and reconciliation are still required.

@michaeljguarino
michaeljguarino merged commit 5b63a59 into master Oct 10, 2026
166 checks passed
@michaeljguarino
michaeljguarino deleted the monitoring-fixes branch October 10, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request hotfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant