Strip stdin & gracefully handle interrupt#33
Open
tacerus wants to merge 2 commits into
Open
Conversation
When piping tools such as openssl or pwgen into "saltstack-age enc", the encrypted value would contain a trailing newline, causing unexpected results in Salt states interpreting the pillar values. Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
When deciding not to proceed with the encryption from stdin, avoid a traceback upon Ctrl+C. Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: strip stdin
When piping tools such as openssl or pwgen into "saltstack-age enc",
the encrypted value would contain a trailing newline, causing unexpected
results in Salt states interpreting the pillar values.
fix: gracefully handle interrupt
When deciding not to proceed with the encryption from stdin, avoid a
traceback upon Ctrl+C.