Repository navigation
feature: Wayland initialization and resource cleanup - #1
Closed
CartridgeSmoker wants to merge 2 commits into
Closed
CartridgeSmoker wants to merge 2 commits into
CartridgeSmoker wants to merge 2 commits into
Conversation
Contributor
|
@CartridgeSmoker you need to explain the changes in person, only then we'll merge them And why did you make changes on topic that you haven't picked ? |
glenv1ew
suggested changes
Sep 21, 2026
Contributor
There was a problem hiding this comment.
wl.h, wl.c are my part, I'll implement it myself
| #include <stdio.h> | ||
| #include <string.h> | ||
|
|
||
| /* ------------------------------------------------------------ |
Contributor
There was a problem hiding this comment.
These columns and comments are too large. Please shorten or remove it
glenv1ew
suggested changes
Sep 21, 2026
| #include <vulkan/vulkan.h> | ||
|
|
||
| #include <wayland-client.h> | ||
| #include "xdg-shell-client-protocol.h" // generated by wayland scanner |
| // window | ||
| struct wl_surface* surface; | ||
| struct xdg_surface* xdg_surface; | ||
| struct xdg_toplevel* xdg_toplevel; |
|
|
||
| // window | ||
| struct wl_surface* surface; | ||
| struct xdg_surface* xdg_surface; |
| * VkDevice | ||
| * | | ||
| * VkQueue | ||
| */ |
| "vkCreateInstance failed with error code %d\n", | ||
| result); | ||
| return false; | ||
| goto fail; |
Contributor
There was a problem hiding this comment.
refactor code. do not use goto
| void vk_finish(struct Vk* vk) { | ||
| if (vk->dev != VK_NULL_HANDLE) { | ||
| vkDeviceWaitIdle(vk->dev); | ||
| vkDestroyDevice(vk->dev, NULL); |
Contributor
There was a problem hiding this comment.
figure out why pAllocator is NULL
| } | ||
|
|
||
| if (vk->surf != VK_NULL_HANDLE) { | ||
| vkDestroySurfaceKHR(vk->inst, vk->surf, NULL); |
Contributor
There was a problem hiding this comment.
figure out why pAllocator is NULL
| // Logical device and queue. | ||
| /* | ||
| * -------------------------------------------------------- | ||
| * Logical device |
| return false; | ||
| } | ||
| /* | ||
| * -------------------------------------------------------- |
| * Vulkan images to VkSurfaceKHR. | ||
| */ | ||
| const char* device_exts[] = { | ||
| VK_KHR_SWAPCHAIN_EXTENSION_NAME, |
Contributor
There was a problem hiding this comment.
clarify what the swapchain is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
basic window functionality done through wl_init() and resource cleanup through wl_finish()