enable building libseccomp from source (downloaded from github) if it is not already installed#5
Open
droundy wants to merge 7 commits intopolachok:masterfrom
Open
enable building libseccomp from source (downloaded from github) if it is not already installed#5droundy wants to merge 7 commits intopolachok:masterfrom
droundy wants to merge 7 commits intopolachok:masterfrom
Conversation
|
-1, sorry. I'd rather have the build fail and get the library from my distribution instead of accidentally compiling an outdated library into my program. |
Contributor
Author
|
Any news from @polachok on whether this is likely to be acceptable? I'd like to publish my crates that use my improvements, so I'd like to know whether or not to fork. |
Owner
|
Sorry for late reply. Would it be OK for you to have this behind a feature flag? I'd like to avoid fragmentation in the ecosystem. |
Contributor
Author
|
Sure, that would be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build.rs script is more than a big hokey, but it works for me (including cross-compiling to i686), so hopefully it is good enough.