Lint Python scripts in .ci-scripts on every PR - #326
Merged
Conversation
The .ci-scripts/release/ Python scripts (github_release.py, ghcr_nightly.py) run only during release/nightly workflows. A syntax error, undefined name, or stale import there breaks a release while a git tag is already pushed -- a feedback loop worth avoiding. Mirrors ponyup's lint-python.yml: a pull_request-triggered job running the pinned ruff Docker image against .ci-scripts. Closes #324 Closes #316
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.ci-scripts/release/Python scripts (github_release.py,ghcr_nightly.py) run only during release and nightly workflows. A syntax error, undefined name, or stale import there breaks a release while a git tag is already pushed.This adds a
pull_request-triggered job that runs the pinned ruff Docker image (ruff 0.15.12) against.ci-scripts, mirroring ponyup'slint-python.yml. Modeled on ponyup, it uses ruff's default rules with no config file. Verified locally that the existing scripts pass with the same pinned image.Closes #324
Closes #316