Guard Cloudsmith exit code before GHCR push in Windows nightlies - #328
Merged
Conversation
In a pwsh step the step's exit code is that of the last native command, so a failed Cloudsmith push followed by a successful GHCR push exits 0 and masks the failure to the primary download source. The Linux/macOS jobs are unaffected because their bash scripts use set -e. Closes #327
ponylang-main
added
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two Windows nightly jobs run the Cloudsmith push and the GHCR push in the same
pwshstep. In apwshstep the step's exit code is that of the last native command, so a failed Cloudsmith push followed by a successful GHCR push would exit 0 — the board goes green, no Zulip alert fires, and the nightly never reaches Cloudsmith, the primary download source.This adds an explicit
$LASTEXITCODEguard after the Cloudsmith push in both Windows jobs, matching what ponyc'srelease.ymlalready does. The Linux/macOS jobs are unaffected because their bash scripts useset -e.Closes #327