Stop passing the removed --link-ldcmd ponyc option - #332
Merged
Conversation
ponyc removed the `--linker` and `--link-ldcmd` command line options (ponylang/ponyc#5452); embedded LLD is now the only linker. Our Linux release builds passed `linker=bfd`, which the Makefile turned into `--link-ldcmd=bfd`, so they now fail with `Unrecognised option`. That flag already had no effect on embedded LLD, so these static binaries were already being linked by it — dropping `linker=bfd` and the Makefile option that produced the flag changes nothing about the output.
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ponyc removed the
--linkerand--link-ldcmdcommand line options (ponylang/ponyc#5452) — embedded LLD is now the only linker. Our Linux release builds passedlinker=bfd, which the Makefile turned into--link-ldcmd=bfd, so the nightly Linux jobs will fail withUnrecognised option: --link-ldcmd=bfdonce they pick up the new ponyc.That flag already had no effect on embedded LLD, so these static binaries were already being linked by it. This drops
linker=bfdfrom the four Linux release scripts and removes the Makefilelinkeroption that produced the flag; the resulting binaries are unchanged.