Align Windows corral version string with Linux and macOS - #335
Merged
Conversation
The Linux and macOS release/nightly scripts pass an explicit version= to make, so the embedded version string is exactly what they pass: <VERSION> for releases and nightly-<date> for nightlies. The Windows workflows called make.ps1 without -Version, so it fell into its default branch and embedded <VERSION>-<sha>. Same source, different version string per platform. Pass -Version to the four Windows build steps so the embedded string matches Linux/macOS. The cloudsmith and GHCR upload versions are unchanged, kept distinct from the embedded value (the date alone for nightly uploads, matching Linux's CLOUDSMITH_VERSION). Closes #333
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux and macOS release/nightly scripts pass an explicit
version=tomake, so the embedded version string is exactly what they pass:<VERSION>for releases andnightly-<date>for nightlies. The Windows workflows calledmake.ps1without-Version, so it fell into its default branch and embedded<VERSION>-<sha>. Same source, different version string per platform.Pass
-Versionto the four Windows build steps so the embedded string matches Linux/macOS. The cloudsmith and GHCR upload versions are unchanged, kept distinct from the embedded value (the date alone for nightly uploads, matching Linux'sCLOUDSMITH_VERSION).Closes #333