Repository navigation
Add pony-lint CI workflow - #54
Merged
Merged
Conversation
Add the pony-lint workflow to run on PRs that touch .pony files. Fix existing style issues: add missing docstrings, add package docstring files for examples, fix assignment indent and call argument formatting, fix line lengths, use method chaining. One remaining file-naming issue (helpers.pony -> evenly_split_data_elements.pony) left for separate discussion.
Switch from pony-lint directly to make lint for consistency with other ponylang projects.
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run pony-lint on PRs that touch .pony files, matching the setup used across other ponylang projects. Fix existing lint issues: add missing docstrings, package docstring files, fix formatting.
One remaining
style/file-namingissue:helpers.ponyshould be namedevenly_split_data_elements.pony(its only type isEvenlySplitDataElements). Left for separate discussion since it's a file rename.