Redesign the process monitor - #237
Merged
Merged
Conversation
ponylang-main
added
status - new
SeanTAllen
added
status - final comment period
SeanTAllen
removed
the
status - final comment period
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesign the standard library's
processpackage soProcessMonitordetects a child's exit from a native per-platform operating-system event, not from its output pipes reaching end-of-file.The pipe-based model can't distinguish a child's exit from a pipe that something else still holds open, so it reports the exit late or never and the program hangs. Detecting the exit directly also closes a kill-after-reap race and a file-descriptor leak on a failed start.
The design was worked out in ponylang/ponyc#5769, with a working implementation in ponylang/ponyc#5770.