Fix libcurl detection in configure.ac on macOS#298
Open
0xfffffffa wants to merge 1 commit intopooler:masterfrom
Open
Fix libcurl detection in configure.ac on macOS#2980xfffffffa wants to merge 1 commit intopooler:masterfrom
0xfffffffa wants to merge 1 commit intopooler:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: configure.ac fails to detect libcurl on macOS
This PR updates configure.ac to properly detect libcurl on macOS systems (e.g., using Homebrew), resolving the following error seen during ./configure:
./configure: line XXXX: syntax error near unexpected token ','
LIBCURL_CHECK_CONFIG(, 7.15.2, , ...)
Changes:
• Added AC_CONFIG_MACRO_DIRS([m4]) to recognize local m4 macros
• Copied libcurl.m4 into m4/ from Homebrew install path
• Ran autoreconf -fvi to regenerate configure scripts correctly
• Confirmed ./configure && make now succeeds on macOS (tested on Apple Silicon with Homebrew-installed curl)
Why it matters:
Without this fix, cpuminer is not buildable out of the box on macOS — which is common for developers and contributors.