Validate open issue and pull request#14
Merged
Merged
Conversation
The --profile option was using Commander.js variadic pattern (<names...>) which caused argument parsing conflicts when placed before positional args. Changes: - Add parseProfiles() helper to handle comma-separated profile values - Change --profile <names...> to --profile <names> for add/remove commands - Update all usages to use parseProfiles() for consistent array handling Users can now specify profiles in any order: ncp add --profile work github # Works correctly ncp add github --profile work # Also works Multiple profiles use comma-separation: ncp add --profile work,personal github Fixes #13
5cf9c9a to
a640e0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --profile option was using Commander.js variadic pattern (<names...>) which caused argument parsing conflicts when placed before positional args.
Changes:
Users can now specify profiles in any order:
ncp add --profile work github # Works correctly
ncp add github --profile work # Also works
Multiple profiles use comma-separation:
ncp add --profile work,personal github
Fixes #13
Pull Request
Description
Type of Change
Related Issues
Changes Made
Added
Changed
Removed
Fixed
Testing
Test Environment
Test Cases
npm test)Test Commands Used
MCP Server Compatibility
Documentation
Performance Impact
Screenshots/Examples
Checklist
Code Quality
Security
Compatibility
Deployment Notes
Reviewer Notes
Additional Context