implementing forge trace - #397
Open
stschiff wants to merge 6 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #397 +/- ##
==========================================
+ Coverage 52.28% 52.34% +0.05%
==========================================
Files 37 37
Lines 6049 6058 +9
Branches 648 648
==========================================
+ Hits 3163 3171 +8
- Misses 2238 2239 +1
Partials 648 648 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stschiff
marked this pull request as ready for review
August 10, 2026 15:17
Member
Author
|
I thought some more about it and decided to rename the new column to |
nevrome
reviewed
Aug 11, 2026
nevrome
left a comment
Member
There was a problem hiding this comment.
Thanks for looking into this! @TCLamnidis will be happy to hear that this will be added soon. I just have three comments:
- I think adding/updating this new column should not be the default, but a
forgeoption. We could call it--traceor--docSourcePacor something like this. To illustrate why I would find this annoying as a default behaviour: I recently prepared the patched versions of the AADR v66 packages. There I wanted a minimal diff to keep things human-readable. A new column would have been very irritating in this context. SourcePackagedoes not fit with the usual column naming scheme in Pascal_Snake_Case. Maybe we should go withSource_Package.- Maybe we should add a more complex test case where a package with the
Source_Packagecolumn gets forged a second time, to see the concatenation in action. Maybe even from two different source packages.
Member
Author
|
Yes to all! One advantage of fixing 1) is that the golden tests won't all get updated. I'll get to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a Forge Trace, which addresses #251.
The implementation is radically simple:
ForgeTracealready exists, a new trace is appended with;.What do you think?
The package is not hard to review, the only relevant changes are in Forge.hs. But of course there are tons of Forge Test packages, which all had to be updated for the golden tests to pass.